Title: [255543] trunk/Tools
- Revision
- 255543
- Author
- [email protected]
- Date
- 2020-02-01 14:26:34 -0800 (Sat, 01 Feb 2020)
Log Message
Closing a MiniBrowser WK2 window does not release the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=203185
Reviewed by Wenson Hsieh.
Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
to avoid a retain cycle that keeps the window controller and WKWebView alive.
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (255542 => 255543)
--- trunk/Tools/ChangeLog 2020-02-01 06:18:18 UTC (rev 255542)
+++ trunk/Tools/ChangeLog 2020-02-01 22:26:34 UTC (rev 255543)
@@ -1,3 +1,16 @@
+2020-02-01 Simon Fraser <[email protected]>
+
+ Closing a MiniBrowser WK2 window does not release the WKWebView
+ https://bugs.webkit.org/show_bug.cgi?id=203185
+
+ Reviewed by Wenson Hsieh.
+
+ Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
+ to avoid a retain cycle that keeps the window controller and WKWebView alive.
+
+ * MiniBrowser/mac/WK2BrowserWindowController.m:
+ (-[WK2BrowserWindowController awakeFromNib]):
+
2020-01-31 David Quesada <[email protected]>
REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges
Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (255542 => 255543)
--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2020-02-01 06:18:18 UTC (rev 255542)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2020-02-01 22:26:34 UTC (rev 255543)
@@ -125,8 +125,11 @@
_textFinder.incrementalSearchingShouldDimContentView = NO;
_textFinder.client = _webView;
_textFinder.findBarContainer = self;
+
+ __weak WKWebView *weakWebView = _webView;
_textFinder.hideInterfaceCallback = ^{
- [_webView _hideFindUI];
+ WKWebView *webView = weakWebView;
+ [webView _hideFindUI];
};
_zoomTextOnly = NO;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
