Title: [255552] trunk
- Revision
- 255552
- Author
- [email protected]
- Date
- 2020-02-02 15:18:47 -0800 (Sun, 02 Feb 2020)
Log Message
ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
https://bugs.webkit.org/show_bug.cgi?id=207071
<rdar://problem/59076249>
Patch by Antoine Quint <[email protected]> on 2020-02-02
Reviewed by Dean Jackson.
Source/WebCore:
We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't
because we wouldn't know how to animate that CSS property.
* animation/AnimationTimeline.cpp:
(WebCore::compileTransitionPropertiesInStyle):
LayoutTests:
The crash is fixed, we can start running the test as expected again.
* platform/ipad/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (255551 => 255552)
--- trunk/LayoutTests/ChangeLog 2020-02-02 21:03:52 UTC (rev 255551)
+++ trunk/LayoutTests/ChangeLog 2020-02-02 23:18:47 UTC (rev 255552)
@@ -1,3 +1,15 @@
+2020-02-02 Antoine Quint <[email protected]>
+
+ ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+ https://bugs.webkit.org/show_bug.cgi?id=207071
+ <rdar://problem/59076249>
+
+ Reviewed by Dean Jackson.
+
+ The crash is fixed, we can start running the test as expected again.
+
+ * platform/ipad/TestExpectations:
+
2020-02-01 Wenson Hsieh <[email protected]>
fast/events/touch/ios/long-press-on-link.html consistently times out after r254699
Modified: trunk/LayoutTests/platform/ipad/TestExpectations (255551 => 255552)
--- trunk/LayoutTests/platform/ipad/TestExpectations 2020-02-02 21:03:52 UTC (rev 255551)
+++ trunk/LayoutTests/platform/ipad/TestExpectations 2020-02-02 23:18:47 UTC (rev 255552)
@@ -63,5 +63,3 @@
webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-004.html [ Pass ]
media/picture-in-picture [ Pass ]
-
-webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (255551 => 255552)
--- trunk/Source/WebCore/ChangeLog 2020-02-02 21:03:52 UTC (rev 255551)
+++ trunk/Source/WebCore/ChangeLog 2020-02-02 23:18:47 UTC (rev 255552)
@@ -1,3 +1,17 @@
+2020-02-02 Antoine Quint <[email protected]>
+
+ ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+ https://bugs.webkit.org/show_bug.cgi?id=207071
+ <rdar://problem/59076249>
+
+ Reviewed by Dean Jackson.
+
+ We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't
+ because we wouldn't know how to animate that CSS property.
+
+ * animation/AnimationTimeline.cpp:
+ (WebCore::compileTransitionPropertiesInStyle):
+
2020-02-01 Michael Catanzaro <[email protected]>
Silence compiler warnings
Modified: trunk/Source/WebCore/animation/AnimationTimeline.cpp (255551 => 255552)
--- trunk/Source/WebCore/animation/AnimationTimeline.cpp 2020-02-02 21:03:52 UTC (rev 255551)
+++ trunk/Source/WebCore/animation/AnimationTimeline.cpp 2020-02-02 23:18:47 UTC (rev 255552)
@@ -415,7 +415,7 @@
auto shorthand = shorthandForProperty(property);
for (size_t j = 0; j < shorthand.length(); ++j)
transitionProperties.add(shorthand.properties()[j]);
- } else
+ } else if (property != CSSPropertyInvalid)
transitionProperties.add(property);
} else if (mode == Animation::AnimateAll) {
transitionPropertiesContainAll = true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
