Title: [255554] trunk/LayoutTests
- Revision
- 255554
- Author
- [email protected]
- Date
- 2020-02-02 20:55:58 -0800 (Sun, 02 Feb 2020)
Log Message
editing/input/composition-highlights.html fails on open source Mojave bots
https://bugs.webkit.org/show_bug.cgi?id=207107
Reviewed by Tim Horton.
This test currently fails consistently on non-internal macOS Mojave bots; for some reason, the width of the
colon character glyph in Times font is 8.4px instead of 4.4px when using CTRunGetAdvancesPtr, causing the
composition highlights to be shifted right 4px and making the ref comparison fail.
Debugging shows that only in macOS Mojave, the CoreText framework adjusts the width of the colon glyph by 4px
in TStorageRange::SetAdvance. This has since been fixed in Catalina, so just work around this for the time being
by changing the editable text from "Test: " to just "Test ".
* editing/input/composition-highlights-expected.html:
* editing/input/composition-highlights.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (255553 => 255554)
--- trunk/LayoutTests/ChangeLog 2020-02-03 04:26:55 UTC (rev 255553)
+++ trunk/LayoutTests/ChangeLog 2020-02-03 04:55:58 UTC (rev 255554)
@@ -1,3 +1,21 @@
+2020-02-02 Wenson Hsieh <[email protected]>
+
+ editing/input/composition-highlights.html fails on open source Mojave bots
+ https://bugs.webkit.org/show_bug.cgi?id=207107
+
+ Reviewed by Tim Horton.
+
+ This test currently fails consistently on non-internal macOS Mojave bots; for some reason, the width of the
+ colon character glyph in Times font is 8.4px instead of 4.4px when using CTRunGetAdvancesPtr, causing the
+ composition highlights to be shifted right 4px and making the ref comparison fail.
+
+ Debugging shows that only in macOS Mojave, the CoreText framework adjusts the width of the colon glyph by 4px
+ in TStorageRange::SetAdvance. This has since been fixed in Catalina, so just work around this for the time being
+ by changing the editable text from "Test: " to just "Test ".
+
+ * editing/input/composition-highlights-expected.html:
+ * editing/input/composition-highlights.html:
+
2020-02-02 Antoine Quint <[email protected]>
ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
Modified: trunk/LayoutTests/editing/input/composition-highlights-expected.html (255553 => 255554)
--- trunk/LayoutTests/editing/input/composition-highlights-expected.html 2020-02-03 04:26:55 UTC (rev 255553)
+++ trunk/LayoutTests/editing/input/composition-highlights-expected.html 2020-02-03 04:55:58 UTC (rev 255554)
@@ -12,6 +12,6 @@
</head>
<body>
This test verifies that highlights can be specified when setting marked text.
-<div contenteditable>Test: <span id="red">one</span><span id="green">two</span><span id="blue">three</span></div>
+<div contenteditable>Test <span id="red">one</span><span id="green">two</span><span id="blue">three</span></div>
</body>
</html>
Modified: trunk/LayoutTests/editing/input/composition-highlights.html (255553 => 255554)
--- trunk/LayoutTests/editing/input/composition-highlights.html 2020-02-03 04:26:55 UTC (rev 255553)
+++ trunk/LayoutTests/editing/input/composition-highlights.html 2020-02-03 04:55:58 UTC (rev 255554)
@@ -11,7 +11,7 @@
</head>
<body>
This test verifies that highlights can be specified when setting marked text.
-<div contenteditable>Test: </div>
+<div contenteditable>Test </div>
<script>
const editor = document.querySelector("div[contenteditable]");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
