Title: [255556] trunk/Source/WebCore
Revision
255556
Author
[email protected]
Date
2020-02-03 02:27:27 -0800 (Mon, 03 Feb 2020)

Log Message

Crash in WebKitAccessible
https://bugs.webkit.org/show_bug.cgi?id=207093
<rdar://problem/59088456>

Patch by Jonathan Kingston <[email protected]> on 2020-02-03
Reviewed by Carlos Garcia Campos.

Fixed a debug crash in WebKitAccessible caused by detatching an accessibility wrapper multiple times.

* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::detachPlatformWrapper):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (255555 => 255556)


--- trunk/Source/WebCore/ChangeLog	2020-02-03 08:59:06 UTC (rev 255555)
+++ trunk/Source/WebCore/ChangeLog	2020-02-03 10:27:27 UTC (rev 255556)
@@ -1,3 +1,16 @@
+2020-02-03  Jonathan Kingston  <[email protected]>
+
+        Crash in WebKitAccessible
+        https://bugs.webkit.org/show_bug.cgi?id=207093
+        <rdar://problem/59088456>
+
+        Reviewed by Carlos Garcia Campos.
+
+        Fixed a debug crash in WebKitAccessible caused by detatching an accessibility wrapper multiple times.
+
+        * accessibility/atk/AccessibilityObjectAtk.cpp:
+        (WebCore::AccessibilityObject::detachPlatformWrapper):
+
 2020-02-03  Pablo Saavedra  <[email protected]>
 
         Build error with -DENABLE_VIDEO_TRACK=OFF after r255151

Modified: trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp (255555 => 255556)


--- trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp	2020-02-03 08:59:06 UTC (rev 255555)
+++ trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp	2020-02-03 10:27:27 UTC (rev 255556)
@@ -38,8 +38,10 @@
 void AccessibilityObject::detachPlatformWrapper(AccessibilityDetachmentType detachmentType)
 {
     if (detachmentType != AccessibilityDetachmentType::CacheDestroyed) {
-        if (auto* cache = axObjectCache())
+        if (auto* cache = axObjectCache()) {
             cache->detachWrapper(this, detachmentType);
+            return;
+        }
     }
 
     auto* wrapper = this->wrapper();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to