Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (255579 => 255580)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2020-02-03 19:39:15 UTC (rev 255579)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2020-02-03 19:41:41 UTC (rev 255580)
@@ -29,7 +29,7 @@
DownloadBuiltProduct, ExtractBuiltProduct, InstallGtkDependencies, InstallWpeDependencies, KillOldProcesses,
PrintConfiguration, RunAPITests, RunBindingsTests, RunBuildWebKitOrgUnitTests, RunEWSBuildbotCheckConfig, RunEWSUnitTests,
RunJavaScriptCoreTests, RunWebKit1Tests, RunWebKitPerlTests,
- RunWebKitPyPython2Tests, RunWebKitPyPython3Tests, RunWebKitTests, UpdateWorkingDirectory, ValidatePatch)
+ RunWebKitPyPython2Tests, RunWebKitPyPython3Tests, RunWebKitTests, SetBuildSummary, UpdateWorkingDirectory, ValidatePatch)
class Factory(factory.BuildFactory):
@@ -89,6 +89,7 @@
Factory.__init__(self, platform=platform, configuration=configuration, architectures=architectures, buildOnly=False, additionalArgument=additionalArguments, checkRelevance=True)
self.addStep(RunWebKitPyPython2Tests())
self.addStep(RunWebKitPyPython3Tests())
+ self.addStep(SetBuildSummary())
class BuildFactory(Factory):
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py (255579 => 255580)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py 2020-02-03 19:39:15 UTC (rev 255579)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py 2020-02-03 19:41:41 UTC (rev 255580)
@@ -136,6 +136,7 @@
_BuildStepFactory(steps.ApplyPatch),
_BuildStepFactory(steps.RunWebKitPyPython2Tests),
_BuildStepFactory(steps.RunWebKitPyPython3Tests),
+ _BuildStepFactory(steps.SetBuildSummary),
])
def test_services_factory(self):
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (255579 => 255580)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-02-03 19:39:15 UTC (rev 255579)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-02-03 19:41:41 UTC (rev 255580)
@@ -725,9 +725,24 @@
self.addLogObserver('json', self.log_observer)
return shell.ShellCommand.start(self)
+ def setBuildSummary(self, build_summary):
+ previous_build_summary = self.getProperty('build_summary', '')
+ if not previous_build_summary:
+ self.setProperty('build_summary', build_summary)
+ return
+
+ if build_summary in previous_build_summary:
+ # Ensure that we do not append same build summary multiple times in case
+ # this method is called multiple times.
+ return
+
+ new_build_summary = previous_build_summary + ', ' + build_summary
+ self.setProperty('build_summary', new_build_summary)
+
def getResultSummary(self):
if self.results == SUCCESS:
message = 'Passed webkitpy {} tests'.format(self.language)
+ self.setBuildSummary(message)
return {u'step': unicode(message)}
logLines = self.log_observer.getStdout()
@@ -743,7 +758,8 @@
return super(WebKitPyTest, self).getResultSummary()
pluralSuffix = 's' if len(failures) > 1 else ''
failures_string = ', '.join([failure.get('name').replace('webkitpy.', '') for failure in failures])
- message = 'Found {} WebKitPy test failure{}: {}'.format(len(failures), pluralSuffix, failures_string)
+ message = 'Found {} webkitpy {} test failure{}: {}'.format(len(failures), self.language, pluralSuffix, failures_string)
+ self.setBuildSummary(message)
return {u'step': unicode(message)}
@defer.inlineCallbacks
Modified: trunk/Tools/ChangeLog (255579 => 255580)
--- trunk/Tools/ChangeLog 2020-02-03 19:39:15 UTC (rev 255579)
+++ trunk/Tools/ChangeLog 2020-02-03 19:41:41 UTC (rev 255580)
@@ -1,3 +1,16 @@
+2020-02-03 Aakash Jain <[email protected]>
+
+ [ews] Set custom build summary for webkitpy tests
+ https://bugs.webkit.org/show_bug.cgi?id=207027
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/factories.py:
+ * BuildSlaveSupport/ews-build/steps.py:
+ (WebKitPyTest.setBuildSummary):
+ (WebKitPyTest.getResultSummary):
+ * BuildSlaveSupport/ews-build/factories_unittest.py:
+
2020-02-03 Jonathan Bedard <[email protected]>
run-_javascript_core-tests: Don't split binary results
