Title: [255635] branches/safari-610.1.1-branch/Source/WebKit
Revision
255635
Author
[email protected]
Date
2020-02-03 19:08:48 -0800 (Mon, 03 Feb 2020)

Log Message

Cherry-pick r255456. rdar://problem/58966044

    REGRESSION (r253267): Swipe from edge on Twitter images no longer goes back
    https://bugs.webkit.org/show_bug.cgi?id=207011
    <rdar://problem/58966044>

    Reviewed by Wenson Hsieh.

    * UIProcess/ios/WKContentViewInteraction.mm:
    (-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
    The new touch-event async deferring gesture recognizer was erroneously deferring
    edge swipes, which are not allowed to be blocked by touch events.
    Opt them out of the new gesture gate mechanism.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610.1.1-branch/Source/WebKit/ChangeLog (255634 => 255635)


--- branches/safari-610.1.1-branch/Source/WebKit/ChangeLog	2020-02-04 03:08:46 UTC (rev 255634)
+++ branches/safari-610.1.1-branch/Source/WebKit/ChangeLog	2020-02-04 03:08:48 UTC (rev 255635)
@@ -1,5 +1,38 @@
 2020-02-03  Russell Epstein  <[email protected]>
 
+        Cherry-pick r255456. rdar://problem/58966044
+
+    REGRESSION (r253267): Swipe from edge on Twitter images no longer goes back
+    https://bugs.webkit.org/show_bug.cgi?id=207011
+    <rdar://problem/58966044>
+    
+    Reviewed by Wenson Hsieh.
+    
+    * UIProcess/ios/WKContentViewInteraction.mm:
+    (-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
+    The new touch-event async deferring gesture recognizer was erroneously deferring
+    edge swipes, which are not allowed to be blocked by touch events.
+    Opt them out of the new gesture gate mechanism.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-30  Tim Horton  <[email protected]>
+
+            REGRESSION (r253267): Swipe from edge on Twitter images no longer goes back
+            https://bugs.webkit.org/show_bug.cgi?id=207011
+            <rdar://problem/58966044>
+
+            Reviewed by Wenson Hsieh.
+
+            * UIProcess/ios/WKContentViewInteraction.mm:
+            (-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
+            The new touch-event async deferring gesture recognizer was erroneously deferring
+            edge swipes, which are not allowed to be blocked by touch events.
+            Opt them out of the new gesture gate mechanism.
+
+2020-02-03  Russell Epstein  <[email protected]>
+
         Cherry-pick r255428. rdar://problem/58900030
 
     [iOS] Remove report rule for 'com.apple.runningboard' from the Network and GPU process sandboxes

Modified: branches/safari-610.1.1-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (255634 => 255635)


--- branches/safari-610.1.1-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-02-04 03:08:46 UTC (rev 255634)
+++ branches/safari-610.1.1-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-02-04 03:08:48 UTC (rev 255635)
@@ -6765,6 +6765,9 @@
 
 - (BOOL)deferringGestureRecognizer:(WKDeferringGestureRecognizer *)deferringGestureRecognizer shouldDeferOtherGestureRecognizer:(UIGestureRecognizer *)gestureRecognizer
 {
+    if ([_webView _isNavigationSwipeGestureRecognizer:gestureRecognizer])
+        return NO;
+
 #if ENABLE(IOS_TOUCH_EVENTS)
     auto isOneFingerMultipleTapGesture = [](UIGestureRecognizer *gesture) -> BOOL {
         if (![gesture isKindOfClass:UITapGestureRecognizer.class])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to