Title: [255629] branches/safari-610.1.1-branch/Source/WebKit
Revision
255629
Author
[email protected]
Date
2020-02-03 19:08:34 -0800 (Mon, 03 Feb 2020)

Log Message

Cherry-pick r255375. rdar://problem/58791603

    Crash under com.apple.WebKit.Networking at WebKit: WebKit::WebIDBServer::suspend
    https://bugs.webkit.org/show_bug.cgi?id=206904
    <rdar://problem/58791603>

    Reviewed by Maciej Stachowiak.

    Wait until m_server is set in constructor of WebIDBServer to make sure m_server can be accessed in
    WebIDBServer::suspend.

    * NetworkProcess/IndexedDB/WebIDBServer.cpp:
    (WebKit::WebIDBServer::WebIDBServer):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610.1.1-branch/Source/WebKit/ChangeLog (255628 => 255629)


--- branches/safari-610.1.1-branch/Source/WebKit/ChangeLog	2020-02-04 03:08:31 UTC (rev 255628)
+++ branches/safari-610.1.1-branch/Source/WebKit/ChangeLog	2020-02-04 03:08:34 UTC (rev 255629)
@@ -1,5 +1,38 @@
 2020-02-03  Russell Epstein  <[email protected]>
 
+        Cherry-pick r255375. rdar://problem/58791603
+
+    Crash under com.apple.WebKit.Networking at WebKit: WebKit::WebIDBServer::suspend
+    https://bugs.webkit.org/show_bug.cgi?id=206904
+    <rdar://problem/58791603>
+    
+    Reviewed by Maciej Stachowiak.
+    
+    Wait until m_server is set in constructor of WebIDBServer to make sure m_server can be accessed in
+    WebIDBServer::suspend.
+    
+    * NetworkProcess/IndexedDB/WebIDBServer.cpp:
+    (WebKit::WebIDBServer::WebIDBServer):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-29  Sihui Liu  <[email protected]>
+
+            Crash under com.apple.WebKit.Networking at WebKit: WebKit::WebIDBServer::suspend
+            https://bugs.webkit.org/show_bug.cgi?id=206904
+            <rdar://problem/58791603>
+
+            Reviewed by Maciej Stachowiak.
+
+            Wait until m_server is set in constructor of WebIDBServer to make sure m_server can be accessed in
+            WebIDBServer::suspend.
+
+            * NetworkProcess/IndexedDB/WebIDBServer.cpp:
+            (WebKit::WebIDBServer::WebIDBServer):
+
+2020-02-03  Russell Epstein  <[email protected]>
+
         Cherry-pick r255366. rdar://problem/58440111
 
     [iOS] Add managed preference to allow legacy sync XHRs during page dismissal

Modified: branches/safari-610.1.1-branch/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp (255628 => 255629)


--- branches/safari-610.1.1-branch/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp	2020-02-04 03:08:31 UTC (rev 255628)
+++ branches/safari-610.1.1-branch/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp	2020-02-04 03:08:34 UTC (rev 255629)
@@ -46,9 +46,12 @@
 {
     ASSERT(RunLoop::isMain());
 
-    postTask([this, protectedThis = makeRef(*this), sessionID, directory = directory.isolatedCopy(), spaceRequester = WTFMove(spaceRequester)] () mutable {
+    BinarySemaphore semaphore;
+    postTask([this, protectedThis = makeRef(*this), &semaphore, sessionID, directory = directory.isolatedCopy(), spaceRequester = WTFMove(spaceRequester)] () mutable {
         m_server = makeUnique<WebCore::IDBServer::IDBServer>(sessionID, directory, WTFMove(spaceRequester));
+        semaphore.signal();
     });
+    semaphore.wait();
 }
     
 void WebIDBServer::closeAndDeleteDatabasesModifiedSince(WallTime modificationTime, CompletionHandler<void()>&& callback)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to