Title: [255633] branches/safari-610.1.1-branch/Source/WebCore
Revision
255633
Author
[email protected]
Date
2020-02-03 19:08:44 -0800 (Mon, 03 Feb 2020)

Log Message

Cherry-pick r255417. rdar://problem/58780773

    Do not notify other applications when deactivating the audio session
    https://bugs.webkit.org/show_bug.cgi?id=206963

    Reviewed by Jer Noble.

    Tested manually because this change is iOS-only and only reproduces on hardware.

    * platform/audio/ios/AudioSessionIOS.mm:
    (WebCore::AudioSession::tryToSetActiveInternal): Don't pass the AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation
    flag to -[AVAudioSession setActive:error].

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610.1.1-branch/Source/WebCore/ChangeLog (255632 => 255633)


--- branches/safari-610.1.1-branch/Source/WebCore/ChangeLog	2020-02-04 03:08:41 UTC (rev 255632)
+++ branches/safari-610.1.1-branch/Source/WebCore/ChangeLog	2020-02-04 03:08:44 UTC (rev 255633)
@@ -1,5 +1,36 @@
 2020-02-03  Russell Epstein  <[email protected]>
 
+        Cherry-pick r255417. rdar://problem/58780773
+
+    Do not notify other applications when deactivating the audio session
+    https://bugs.webkit.org/show_bug.cgi?id=206963
+    
+    Reviewed by Jer Noble.
+    
+    Tested manually because this change is iOS-only and only reproduces on hardware.
+    
+    * platform/audio/ios/AudioSessionIOS.mm:
+    (WebCore::AudioSession::tryToSetActiveInternal): Don't pass the AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation
+    flag to -[AVAudioSession setActive:error].
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-29  Eric Carlson  <[email protected]>
+
+            Do not notify other applications when deactivating the audio session
+            https://bugs.webkit.org/show_bug.cgi?id=206963
+
+            Reviewed by Jer Noble.
+
+            Tested manually because this change is iOS-only and only reproduces on hardware.
+
+            * platform/audio/ios/AudioSessionIOS.mm:
+            (WebCore::AudioSession::tryToSetActiveInternal): Don't pass the AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation
+            flag to -[AVAudioSession setActive:error].
+
+2020-02-03  Russell Epstein  <[email protected]>
+
         Cherry-pick r255400. rdar://problem/58838711
 
     Set QoS of blobUtilityQueue to be Utility

Modified: branches/safari-610.1.1-branch/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm (255632 => 255633)


--- branches/safari-610.1.1-branch/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2020-02-04 03:08:41 UTC (rev 255632)
+++ branches/safari-610.1.1-branch/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2020-02-04 03:08:44 UTC (rev 255633)
@@ -224,7 +224,7 @@
     }
 
     dispatch_async(m_private->m_dispatchQueue.get(), ^{
-        [[PAL::getAVAudioSessionClass() sharedInstance] setActive:NO withOptions:AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation error:&error];
+        [[PAL::getAVAudioSessionClass() sharedInstance] setActive:NO withOptions:0 error:&error];
     });
 
     return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to