Title: [255665] trunk/Source/WebCore
- Revision
- 255665
- Author
- [email protected]
- Date
- 2020-02-04 00:04:08 -0800 (Tue, 04 Feb 2020)
Log Message
[WinCairo][curl][Clang] error: member access into incomplete type 'WebCore::SynchronousLoaderMessageQueue' in ~CurlRequest
https://bugs.webkit.org/show_bug.cgi?id=207187
Unreviewed build fix for clang-cl builds of WinCairo port.
SynchronousLoaderMessageQueue couldn't be destructed in inlined
~CurlRequest because it's a incomplete type. Moved the dtor from
CurlRequest.h to CurlRequest.cpp.
* platform/network/curl/CurlRequest.cpp:
* platform/network/curl/CurlRequest.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (255664 => 255665)
--- trunk/Source/WebCore/ChangeLog 2020-02-04 06:04:12 UTC (rev 255664)
+++ trunk/Source/WebCore/ChangeLog 2020-02-04 08:04:08 UTC (rev 255665)
@@ -1,3 +1,17 @@
+2020-02-03 Fujii Hironori <[email protected]>
+
+ [WinCairo][curl][Clang] error: member access into incomplete type 'WebCore::SynchronousLoaderMessageQueue' in ~CurlRequest
+ https://bugs.webkit.org/show_bug.cgi?id=207187
+
+ Unreviewed build fix for clang-cl builds of WinCairo port.
+
+ SynchronousLoaderMessageQueue couldn't be destructed in inlined
+ ~CurlRequest because it's a incomplete type. Moved the dtor from
+ CurlRequest.h to CurlRequest.cpp.
+
+ * platform/network/curl/CurlRequest.cpp:
+ * platform/network/curl/CurlRequest.h:
+
2020-02-03 Antti Koivisto <[email protected]>
Accelerated animations freeze on render tree rebuild
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (255664 => 255665)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2020-02-04 06:04:12 UTC (rev 255664)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2020-02-04 08:04:08 UTC (rev 255665)
@@ -54,6 +54,8 @@
ASSERT(isMainThread());
}
+CurlRequest::~CurlRequest() = default;
+
void CurlRequest::invalidateClient()
{
ASSERT(isMainThread());
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.h (255664 => 255665)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.h 2020-02-04 06:04:12 UTC (rev 255664)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.h 2020-02-04 08:04:08 UTC (rev 255665)
@@ -69,7 +69,7 @@
return adoptRef(*new CurlRequest(request, &client, shouldSuspend, enableMultipart, captureMetrics, WTFMove(messageQueue)));
}
- virtual ~CurlRequest() = default;
+ virtual ~CurlRequest();
void invalidateClient();
WEBCORE_EXPORT void setAuthenticationScheme(ProtectionSpaceAuthenticationScheme);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
