Title: [255695] trunk/Tools
- Revision
- 255695
- Author
- [email protected]
- Date
- 2020-02-04 14:05:35 -0800 (Tue, 04 Feb 2020)
Log Message
TestWebKitAPI: Handle case where test result does not contain path
https://bugs.webkit.org/show_bug.cgi?id=207216
Reviewed by Tim Horton.
* TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
will not contain a file name. We should handle this case.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (255694 => 255695)
--- trunk/Tools/ChangeLog 2020-02-04 22:02:08 UTC (rev 255694)
+++ trunk/Tools/ChangeLog 2020-02-04 22:05:35 UTC (rev 255695)
@@ -1,5 +1,16 @@
2020-02-04 Jonathan Bedard <[email protected]>
+ TestWebKitAPI: Handle case where test result does not contain path
+ https://bugs.webkit.org/show_bug.cgi?id=207216
+
+ Reviewed by Tim Horton.
+
+ * TestWebKitAPI/TestsController.cpp:
+ (TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
+ will not contain a file name. We should handle this case.
+
+2020-02-04 Jonathan Bedard <[email protected]>
+
results.webkit.org: Better order upload callbacks
https://bugs.webkit.org/show_bug.cgi?id=207219
Modified: trunk/Tools/TestWebKitAPI/TestsController.cpp (255694 => 255695)
--- trunk/Tools/TestWebKitAPI/TestsController.cpp 2020-02-04 22:02:08 UTC (rev 255694)
+++ trunk/Tools/TestWebKitAPI/TestsController.cpp 2020-02-04 22:05:35 UTC (rev 255695)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010, 2020 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -40,7 +40,12 @@
return;
std::stringstream stream;
- stream << "\n" << test_part_result.file_name() << ":" << test_part_result.line_number() << "\n" << test_part_result.summary() << "\n\n";
+ stream << "\n";
+ if (test_part_result.file_name())
+ stream << test_part_result.file_name() << ":" << test_part_result.line_number();
+ else
+ stream << "File name unavailable";
+ stream << "\n" << test_part_result.summary() << "\n\n";
failures += stream.str();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
