Title: [255825] trunk/LayoutTests
Revision
255825
Author
[email protected]
Date
2020-02-05 10:08:03 -0800 (Wed, 05 Feb 2020)

Log Message

REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207194
<rdar://problem/59148073>

Reviewed by Wenson Hsieh.

Test was flaky because it relied on a 10ms timer.

* fast/scrolling/ios/scroll-events-back-forward-expected.txt:
* fast/scrolling/ios/scroll-events-back-forward.html:
* platform/ios-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (255824 => 255825)


--- trunk/LayoutTests/ChangeLog	2020-02-05 18:06:02 UTC (rev 255824)
+++ trunk/LayoutTests/ChangeLog	2020-02-05 18:08:03 UTC (rev 255825)
@@ -1,3 +1,17 @@
+2020-02-05  Chris Dumez  <[email protected]>
+
+        REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=207194
+        <rdar://problem/59148073>
+
+        Reviewed by Wenson Hsieh.
+
+        Test was flaky because it relied on a 10ms timer.
+
+        * fast/scrolling/ios/scroll-events-back-forward-expected.txt:
+        * fast/scrolling/ios/scroll-events-back-forward.html:
+        * platform/ios-wk2/TestExpectations:
+
 2020-02-05  Jason Lawrence  <[email protected]>
 
         [iOS wk2 Debug] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001.html is failing

Modified: trunk/LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt (255824 => 255825)


--- trunk/LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt	2020-02-05 18:06:02 UTC (rev 255824)
+++ trunk/LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt	2020-02-05 18:08:03 UTC (rev 255825)
@@ -5,7 +5,7 @@
 
 pageshow 0
 pageshow 1
-PASS scrollEventCount is 1
+PASS scrollEventCount became 1
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html (255824 => 255825)


--- trunk/LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html	2020-02-05 18:06:02 UTC (rev 255824)
+++ trunk/LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html	2020-02-05 18:08:03 UTC (rev 255825)
@@ -2,7 +2,7 @@
 <!DOCTYPE html>
 <html>
 <head>
-  <script src=""
+  <script src=""
   <style>
     body {
       height: 2000px;
@@ -10,11 +10,9 @@
   </style>
 </head>
 <body>
-<p id="description"></p>
-<div id="console"></div>
-
 <script>
 description('Tests that scroll event listeners still work after going back to a page in the page cache.');
+jsTestIsAsync = true;
 
 function testScrollListener(message)
 {
@@ -32,11 +30,8 @@
   debug('pageshow ' + pageShowCount);
   if (++pageShowCount == 2) {
       testScrollListener('After going back');
-      window.setTimeout(function() {
-        shouldBe('scrollEventCount', '1');
-        finishJSTest();
-      }, 10);
-    }
+      shouldBecomeEqual('scrollEventCount', '1', finishJSTest);
+  }
 }
 
 function onPageLoad()
@@ -49,11 +44,6 @@
 
 window.addEventListener('load', onPageLoad, false);
 window.addEventListener('pageshow', onPageShow, false);
-
-var successfullyParsed = true;
-var jsTestIsAsync = true;
 </script> 
-
-<script src=""
 </body>
 </html>

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (255824 => 255825)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-05 18:06:02 UTC (rev 255824)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-05 18:08:03 UTC (rev 255825)
@@ -1373,10 +1373,8 @@
 
 webkit.org/b/207164 [ Debug ] legacy-animation-engine/animations/play-state-in-shorthand.html [ Pass Failure ]
 
-webkit.org/b/207194 fast/scrolling/ios/scroll-events-back-forward.html [ Pass Failure ]
-
 webkit.org/b/207197 http/tests/resourceLoadStatistics/cookie-deletion.html [ Pass Failure Crash ]
 
 webkit.org/b/206627 storage/websql [ Skip ]
 
-webkit.org/b/207077 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207077 [ Debug ] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to