Title: [255926] releases/WebKitGTK/webkit-2.28/Source/WebKit
- Revision
- 255926
- Author
- [email protected]
- Date
- 2020-02-06 07:10:12 -0800 (Thu, 06 Feb 2020)
Log Message
Merge r255851 - [IPC Hardening] Protect against null String under WebInspectorProxy::save() / WebInspectorProxy::append()
https://bugs.webkit.org/show_bug.cgi?id=207284
<rdar://problem/55271616>
Reviewed by David Kilzer.
* UIProcess/Inspector/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::save):
(WebKit::WebInspectorProxy::append):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog (255925 => 255926)
--- releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog 2020-02-06 15:10:08 UTC (rev 255925)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog 2020-02-06 15:10:12 UTC (rev 255926)
@@ -1,5 +1,17 @@
2020-02-05 Chris Dumez <[email protected]>
+ [IPC Hardening] Protect against null String under WebInspectorProxy::save() / WebInspectorProxy::append()
+ https://bugs.webkit.org/show_bug.cgi?id=207284
+ <rdar://problem/55271616>
+
+ Reviewed by David Kilzer.
+
+ * UIProcess/Inspector/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::save):
+ (WebKit::WebInspectorProxy::append):
+
+2020-02-05 Chris Dumez <[email protected]>
+
[IPC Hardening] Protect against m_inspectorPage being null in WebInspectorProxy::setAttachedWindowHeight() / setAttachedWindowWidth()
https://bugs.webkit.org/show_bug.cgi?id=207287
<rdar://problem/55422919>
Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp (255925 => 255926)
--- releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp 2020-02-06 15:10:08 UTC (rev 255925)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp 2020-02-06 15:10:12 UTC (rev 255926)
@@ -629,11 +629,19 @@
void WebInspectorProxy::save(const String& filename, const String& content, bool base64Encoded, bool forceSaveAs)
{
+ ASSERT(!filename.isEmpty());
+ if (filename.isEmpty())
+ return;
+
platformSave(filename, content, base64Encoded, forceSaveAs);
}
void WebInspectorProxy::append(const String& filename, const String& content)
{
+ ASSERT(!filename.isEmpty());
+ if (filename.isEmpty())
+ return;
+
platformAppend(filename, content);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
