Title: [255943] releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI
- Revision
- 255943
- Author
- [email protected]
- Date
- 2020-02-06 07:11:32 -0800 (Thu, 06 Feb 2020)
Log Message
Merge r255892 - Web Inspector: Network: the resource detail view cuts off the bottom statistics bar
https://bugs.webkit.org/show_bug.cgi?id=207320
Reviewed by Timothy Hatcher.
* UserInterface/Views/Variables.css:
(:root):
Add a `--network-statistics-height` variable.
* UserInterface/Views/NetworkDetailView.css:
(.network-detail):
* UserInterface/Views/NetworkTableContentView.css:
(.network-table > .statistics):
Use the `--network-statistics-height` variable to make sure the statistics row and the
details view for the selected network entry don't overlap.
Drive-by: center the content of the statistics row to better match the system look/feel.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog (255942 => 255943)
--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog 2020-02-06 15:11:29 UTC (rev 255942)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog 2020-02-06 15:11:32 UTC (rev 255943)
@@ -1,5 +1,24 @@
2020-02-05 Devin Rousso <[email protected]>
+ Web Inspector: Network: the resource detail view cuts off the bottom statistics bar
+ https://bugs.webkit.org/show_bug.cgi?id=207320
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/Variables.css:
+ (:root):
+ Add a `--network-statistics-height` variable.
+
+ * UserInterface/Views/NetworkDetailView.css:
+ (.network-detail):
+ * UserInterface/Views/NetworkTableContentView.css:
+ (.network-table > .statistics):
+ Use the `--network-statistics-height` variable to make sure the statistics row and the
+ details view for the selected network entry don't overlap.
+ Drive-by: center the content of the statistics row to better match the system look/feel.
+
+2020-02-05 Devin Rousso <[email protected]>
+
Web Inspector: increase the height of the tab bar to match other navigation bars
https://bugs.webkit.org/show_bug.cgi?id=207317
Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.css (255942 => 255943)
--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.css 2020-02-06 15:11:29 UTC (rev 255942)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.css 2020-02-06 15:11:32 UTC (rev 255943)
@@ -28,7 +28,7 @@
top: 0;
left: 0;
right: 0;
- bottom: 0;
+ bottom: var(--network-statistics-height);
/* left or right set by NetworkTableView on display / resize */
z-index: 10;
background-color: white;
Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css (255942 => 255943)
--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css 2020-02-06 15:11:29 UTC (rev 255942)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css 2020-02-06 15:11:32 UTC (rev 255943)
@@ -322,7 +322,9 @@
.network-table > .statistics {
display: flex;
+ justify-content: center;
align-items: center;
+ min-height: var(--network-statistics-height);
padding: 4px 0;
border-top: 1px solid var(--border-color);
}
Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/Variables.css (255942 => 255943)
--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/Variables.css 2020-02-06 15:11:29 UTC (rev 255942)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/Variables.css 2020-02-06 15:11:32 UTC (rev 255943)
@@ -162,6 +162,8 @@
--cpu-medium-color: hsl(46, 91%, 62%);
--cpu-high-color: hsl(6, 79%, 57%);
+ --network-statistics-height: var(--navigation-bar-height);
+
--network-header-color: hsl(204, 52%, 55%);
--network-system-color: hsl(79, 32%, 50%);
--network-pseudo-header-color: hsl(312, 35%, 51%);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
