Title: [255942] releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI
Revision
255942
Author
[email protected]
Date
2020-02-06 07:11:29 -0800 (Thu, 06 Feb 2020)

Log Message

Merge r255890 - Web Inspector: increase the height of the tab bar to match other navigation bars
https://bugs.webkit.org/show_bug.cgi?id=207317

Reviewed by Timothy Hatcher.

* UserInterface/Views/Variables.css:
(:root):
Define `--tab-bar-height` in terms of `--navigation-bar-height` so they share the same value.

* UserInterface/Views/TabBar.css:
(.tab-bar > .tabs > .item):
(.tab-bar > .tabs > .item.pinned):
(.tab-bar > .tabs > .item.pinned.tab-picker): Deleted.
Increase the width to match the `--tab-bar-height` so that pinned tab bar items are square.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog (255941 => 255942)


--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog	2020-02-06 15:11:25 UTC (rev 255941)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog	2020-02-06 15:11:29 UTC (rev 255942)
@@ -1,3 +1,20 @@
+2020-02-05  Devin Rousso  <[email protected]>
+
+        Web Inspector: increase the height of the tab bar to match other navigation bars
+        https://bugs.webkit.org/show_bug.cgi?id=207317
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/Variables.css:
+        (:root):
+        Define `--tab-bar-height` in terms of `--navigation-bar-height` so they share the same value.
+
+        * UserInterface/Views/TabBar.css:
+        (.tab-bar > .tabs > .item):
+        (.tab-bar > .tabs > .item.pinned):
+        (.tab-bar > .tabs > .item.pinned.tab-picker): Deleted.
+        Increase the width to match the `--tab-bar-height` so that pinned tab bar items are square.
+
 2020-02-05  Nikita Vasilyev  <[email protected]>
 
         Web Inspector: Dragging handles in the easing popover selects sidebar text

Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/TabBar.css (255941 => 255942)


--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2020-02-06 15:11:25 UTC (rev 255941)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2020-02-06 15:11:29 UTC (rev 255942)
@@ -134,7 +134,7 @@
 
     padding: 0 6px;
 
-    min-width: 24px;
+    min-width: calc(var(--tab-bar-height) - 1px); /* subtract the width of the border */
     overflow: hidden;
 
     background-image: linear-gradient(to bottom, hsl(0, 0%, 78%), hsl(0, 0%, 72%));
@@ -169,16 +169,10 @@
 }
 
 .tab-bar > .tabs > .item.pinned {
-    width: 24px;
     flex: none;
     justify-content: center;
 }
 
-.tab-bar > .tabs > .item.pinned.tab-picker {
-    width: 18px;
-    min-width: initial;
-}
-
 .tab-bar > .tabs > .item:not(.disabled).selected {
     background-image: linear-gradient(to bottom, hsl(0, 0%, 87%), hsl(0, 0%, 82%));
     background-size: 100% 100%;

Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/Variables.css (255941 => 255942)


--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/Variables.css	2020-02-06 15:11:25 UTC (rev 255941)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/Variables.css	2020-02-06 15:11:29 UTC (rev 255942)
@@ -180,7 +180,8 @@
     --transparent-stripe-background-gradient: linear-gradient(to bottom, transparent, transparent 50%, hsla(0, 0%, 0%, 0.03) 50%, hsla(0, 0%, 0%, 0.03)) top left / 100% 40px;
 
     --undocked-title-area-height: 0px;
-    --tab-bar-height: 24px;
+    --tab-bar-height: var(--navigation-bar-height);
+
     --navigation-bar-height: 29px;
 
     --slider-width: 11px;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to