Title: [255932] releases/WebKitGTK/webkit-2.28/Source/WebKit
- Revision
- 255932
- Author
- [email protected]
- Date
- 2020-02-06 07:10:33 -0800 (Thu, 06 Feb 2020)
Log Message
Merge r255867 - [IPC hardening] Protect against bad parameters in NetworkRTCProvider::createResolver()
https://bugs.webkit.org/show_bug.cgi?id=207301
<rdar://problem/59011449>
Reviewed by Alex Christensen.
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createResolver):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog (255931 => 255932)
--- releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog 2020-02-06 15:10:28 UTC (rev 255931)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog 2020-02-06 15:10:33 UTC (rev 255932)
@@ -1,3 +1,14 @@
+2020-02-05 Chris Dumez <[email protected]>
+
+ [IPC hardening] Protect against bad parameters in NetworkRTCProvider::createResolver()
+ https://bugs.webkit.org/show_bug.cgi?id=207301
+ <rdar://problem/59011449>
+
+ Reviewed by Alex Christensen.
+
+ * NetworkProcess/webrtc/NetworkRTCProvider.cpp:
+ (WebKit::NetworkRTCProvider::createResolver):
+
2020-02-05 Patrick Griffis <[email protected]>
[GTK][WPE] Add more fontconfig paths into the sandbox
Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp (255931 => 255932)
--- releases/WebKitGTK/webkit-2.28/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2020-02-06 15:10:28 UTC (rev 255931)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2020-02-06 15:10:33 UTC (rev 255932)
@@ -205,6 +205,11 @@
void NetworkRTCProvider::createResolver(uint64_t identifier, const String& address)
{
+ ASSERT(m_resolvers.isValidKey(identifier));
+ ASSERT(!address.isEmpty());
+ if (!m_resolvers.isValidKey(identifier) || address.isEmpty())
+ return;
+
auto resolver = NetworkRTCResolver::create(identifier, [this, identifier](WebCore::DNSAddressesOrError&& result) mutable {
if (!result.has_value()) {
if (result.error() != WebCore::DNSError::Cancelled)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
