[webkit-changes] [255946] releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI

Thu, 06 Feb 2020 07:13:45 -0800

Title: [255946] releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI
Revision
255946
Author
[email protected]
Date
2020-02-06 07:11:43 -0800 (Thu, 06 Feb 2020)

Log Message

Merge r255896 - Web Inspector: Some cookie table column headers should not be localizable
https://bugs.webkit.org/show_bug.cgi?id=206920

Reviewed by Timothy Hatcher.

Keep headers that match cookie directives always in English.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView.prototype.initialLayout):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog (255945 => 255946)


--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog	2020-02-06 15:11:39 UTC (rev 255945)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/ChangeLog	2020-02-06 15:11:43 UTC (rev 255946)
@@ -1,3 +1,16 @@
+2020-02-05  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: Some cookie table column headers should not be localizable
+        https://bugs.webkit.org/show_bug.cgi?id=206920
+
+        Reviewed by Timothy Hatcher.
+
+        Keep headers that match cookie directives always in English.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/CookieStorageContentView.js:
+        (WI.CookieStorageContentView.prototype.initialLayout):
+
 2020-02-05  Devin Rousso  <[email protected]>
 
         Web Inspector: slightly increase the horizontal padding around scope bar items

Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (255945 => 255946)


--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2020-02-06 15:11:39 UTC (rev 255945)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2020-02-06 15:11:43 UTC (rev 255946)
@@ -533,7 +533,6 @@
 localizedStrings["Expand columns"] = "Expand columns";
 localizedStrings["Expanded"] = "Expanded";
 localizedStrings["Experimental"] = "Experimental";
-localizedStrings["Expires"] = "Expires";
 localizedStrings["Export"] = "Export";
 localizedStrings["Export (%s)"] = "Export (%s)";
 localizedStrings["Export HAR"] = "Export HAR";

Modified: releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js (255945 => 255946)


--- releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js	2020-02-06 15:11:39 UTC (rev 255945)
+++ releases/WebKitGTK/webkit-2.28/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js	2020-02-06 15:11:43 UTC (rev 255946)
@@ -180,19 +180,19 @@
             hideable: false,
         });
 
-        this._domainColumn = new WI.TableColumn("domain", WI.UIString("Domain"), {
+        this._domainColumn = new WI.TableColumn("domain", WI.unlocalizedString("Domain"), {
             minWidth: 100,
             maxWidth: 200,
             initialWidth: 120,
         });
 
-        this._pathColumn = new WI.TableColumn("path", WI.UIString("Path"), {
+        this._pathColumn = new WI.TableColumn("path", WI.unlocalizedString("Path"), {
             minWidth: 50,
             maxWidth: 300,
             initialWidth: 100,
         });
 
-        this._expiresColumn = new WI.TableColumn("expires", WI.UIString("Expires"), {
+        this._expiresColumn = new WI.TableColumn("expires", WI.unlocalizedString("Expires"), {
             minWidth: 100,
             maxWidth: 200,
             initialWidth: 150,

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to