Title: [255980] trunk/Source/WebInspectorUI
- Revision
- 255980
- Author
- [email protected]
- Date
- 2020-02-06 14:15:36 -0800 (Thu, 06 Feb 2020)
Log Message
Web Inspector: REGRESSION(?): Search: selecting a DOM node search result switches to the Elements Tab
https://bugs.webkit.org/show_bug.cgi?id=207322
Reviewed by Timothy Hatcher.
* UserInterface/Views/TabBrowser.js:
(WI.TabBrowser.prototype._tabBarItemSelected):
The Search Tab is marked such that it isn't saved to `WI._openTabsSetting`, as otherwise
more than one Search Tab could be added to the tab bar (one from the setting and one from
the default pinned tab). It is also marked as being pinned, however, meaning that we know it
will always be in the tab bar, even if we also know it won't be in `WI._openTabsSetting`. As
such, we should update it's position in the `_recentTabContentViews` list so that we can use
it when showing represented objects (if able) via `bestTabContentViewForRepresentedObject`.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (255979 => 255980)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-02-06 22:15:19 UTC (rev 255979)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-02-06 22:15:36 UTC (rev 255980)
@@ -1,3 +1,19 @@
+2020-02-06 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION(?): Search: selecting a DOM node search result switches to the Elements Tab
+ https://bugs.webkit.org/show_bug.cgi?id=207322
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TabBrowser.js:
+ (WI.TabBrowser.prototype._tabBarItemSelected):
+ The Search Tab is marked such that it isn't saved to `WI._openTabsSetting`, as otherwise
+ more than one Search Tab could be added to the tab bar (one from the setting and one from
+ the default pinned tab). It is also marked as being pinned, however, meaning that we know it
+ will always be in the tab bar, even if we also know it won't be in `WI._openTabsSetting`. As
+ such, we should update it's position in the `_recentTabContentViews` list so that we can use
+ it when showing represented objects (if able) via `bestTabContentViewForRepresentedObject`.
+
2020-02-05 Devin Rousso <[email protected]>
Web Inspector: the height of the undocked title area shouldn't change when zoomed
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js (255979 => 255980)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2020-02-06 22:15:19 UTC (rev 255979)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2020-02-06 22:15:36 UTC (rev 255980)
@@ -231,7 +231,8 @@
let tabContentView = this._tabBar.selectedTabBarItem ? this._tabBar.selectedTabBarItem.representedObject : null;
if (tabContentView) {
- let shouldSaveTab = tabContentView.constructor.shouldSaveTab();
+ let tabClass = tabContentView.constructor;
+ let shouldSaveTab = tabClass.shouldSaveTab() || tabClass.shouldPinTab();
if (shouldSaveTab) {
this._recentTabContentViews.remove(tabContentView);
this._recentTabContentViews.unshift(tabContentView);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
