Title: [255982] trunk
- Revision
- 255982
- Author
- [email protected]
- Date
- 2020-02-06 14:28:50 -0800 (Thu, 06 Feb 2020)
Log Message
Web Inspector: REGRESSION(r249831): Sources: endless spinner when trying to view a resource
https://bugs.webkit.org/show_bug.cgi?id=207346
<rdar://problem/59209016>
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
* UserInterface/Workers/Formatter/HTMLParser.js:
(HTMLParser.prototype._parseAttr):
Attributes are allowed to contain "/".
https://html.spec.whatwg.org/multipage/parsing.html#before-attribute-value-state
LayoutTests:
* inspector/formatting/resources/html-tests/attributes.html:
* inspector/formatting/resources/html-tests/attributes-expected.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (255981 => 255982)
--- trunk/LayoutTests/ChangeLog 2020-02-06 22:23:04 UTC (rev 255981)
+++ trunk/LayoutTests/ChangeLog 2020-02-06 22:28:50 UTC (rev 255982)
@@ -1,3 +1,14 @@
+2020-02-06 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION(r249831): Sources: endless spinner when trying to view a resource
+ https://bugs.webkit.org/show_bug.cgi?id=207346
+ <rdar://problem/59209016>
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/formatting/resources/html-tests/attributes.html:
+ * inspector/formatting/resources/html-tests/attributes-expected.html:
+
2020-02-06 Truitt Savell <[email protected]>
Fix my mistakenly landed expectations from r255962
Modified: trunk/LayoutTests/inspector/formatting/resources/html-tests/attributes-expected.html (255981 => 255982)
--- trunk/LayoutTests/inspector/formatting/resources/html-tests/attributes-expected.html 2020-02-06 22:23:04 UTC (rev 255981)
+++ trunk/LayoutTests/inspector/formatting/resources/html-tests/attributes-expected.html 2020-02-06 22:28:50 UTC (rev 255982)
@@ -15,6 +15,7 @@
<p attr='value 1 2 3'></p>
<p attr=value1 attr=value2></p>
<p a=1 b=2></p>
+<p href1=#fragment href2=/path/page.html href3=example.org href4=//example.org href5=http://example.org></p>
<p a=1 b=2></p>
Modified: trunk/LayoutTests/inspector/formatting/resources/html-tests/attributes.html (255981 => 255982)
--- trunk/LayoutTests/inspector/formatting/resources/html-tests/attributes.html 2020-02-06 22:23:04 UTC (rev 255981)
+++ trunk/LayoutTests/inspector/formatting/resources/html-tests/attributes.html 2020-02-06 22:28:50 UTC (rev 255982)
@@ -15,6 +15,7 @@
<p attr= 'value 1 2 3' ></p>
<p attr=value1 attr=value2></p>
<p a=1 b=2></p>
+<p href1=#fragment href2=/path/page.html href3=example.org href4=//example.org href5=http://example.org></p>
<p
a
Modified: trunk/Source/WebInspectorUI/ChangeLog (255981 => 255982)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-02-06 22:23:04 UTC (rev 255981)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-02-06 22:28:50 UTC (rev 255982)
@@ -1,5 +1,18 @@
2020-02-06 Devin Rousso <[email protected]>
+ Web Inspector: REGRESSION(r249831): Sources: endless spinner when trying to view a resource
+ https://bugs.webkit.org/show_bug.cgi?id=207346
+ <rdar://problem/59209016>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Workers/Formatter/HTMLParser.js:
+ (HTMLParser.prototype._parseAttr):
+ Attributes are allowed to contain "/".
+ https://html.spec.whatwg.org/multipage/parsing.html#before-attribute-value-state
+
+2020-02-06 Devin Rousso <[email protected]>
+
Web Inspector: REGRESSION(?): Search: selecting a DOM node search result switches to the Elements Tab
https://bugs.webkit.org/show_bug.cgi?id=207322
Modified: trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLParser.js (255981 => 255982)
--- trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLParser.js 2020-02-06 22:23:04 UTC (rev 255981)
+++ trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLParser.js 2020-02-06 22:28:50 UTC (rev 255982)
@@ -363,7 +363,7 @@
return;
}
- let attributeValue = this._consumeRegex(/[^\s=/>]+/);
+ let attributeValue = this._consumeRegex(/[^\s=>]+/);
this._pushAttribute({name: attributeName, value: attributeValue, quote: HTMLParser.AttrQuoteType.None, namePos: attributeNameStartPos, valuePos: attributeValueStartPos});
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
