Title: [255990] trunk/Source/WebCore
- Revision
- 255990
- Author
- [email protected]
- Date
- 2020-02-06 15:39:20 -0800 (Thu, 06 Feb 2020)
Log Message
webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html is timing out on some hardware configurations
https://bugs.webkit.org/show_bug.cgi?id=205739
Patch by James Darpinian <[email protected]> on 2020-02-06
Reviewed by Dean Jackson.
Optimize disabling ANGLE_texture_rectangle.
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::compileShader):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (255989 => 255990)
--- trunk/Source/WebCore/ChangeLog 2020-02-06 23:35:07 UTC (rev 255989)
+++ trunk/Source/WebCore/ChangeLog 2020-02-06 23:39:20 UTC (rev 255990)
@@ -1,3 +1,15 @@
+2020-02-06 James Darpinian <[email protected]>
+
+ webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html is timing out on some hardware configurations
+ https://bugs.webkit.org/show_bug.cgi?id=205739
+
+ Reviewed by Dean Jackson.
+
+ Optimize disabling ANGLE_texture_rectangle.
+
+ * platform/graphics/angle/GraphicsContextGLANGLE.cpp:
+ (WebCore::GraphicsContextGLOpenGL::compileShader):
+
2020-02-06 Myles C. Maxfield <[email protected]>
REGRESSION(r254534): 1-3% regression on PLT
Modified: trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp (255989 => 255990)
--- trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp 2020-02-06 23:35:07 UTC (rev 255989)
+++ trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp 2020-02-06 23:39:20 UTC (rev 255990)
@@ -822,12 +822,12 @@
{
ASSERT(shader);
makeContextCurrent();
- // We need this extension to support IOSurface backbuffers, but we
- // don't want it exposed to WebGL user shaders. Temporarily disable
- // it during shader compilation.
- gl::DisableExtensionANGLE("GL_ANGLE_texture_rectangle");
+ // We need the ANGLE_texture_rectangle extension to support IOSurface
+ // backbuffers, but we don't want it exposed to WebGL user shaders.
+ // Temporarily disable it during shader compilation.
+ gl::Disable(GL_TEXTURE_RECTANGLE_ANGLE);
gl::CompileShader(shader);
- gl::RequestExtensionANGLE("GL_ANGLE_texture_rectangle");
+ gl::Enable(GL_TEXTURE_RECTANGLE_ANGLE);
}
void GraphicsContextGLOpenGL::compileShaderDirect(PlatformGLObject shader)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
