Title: [256094] trunk/Source/WebCore
- Revision
- 256094
- Author
- [email protected]
- Date
- 2020-02-08 13:54:58 -0800 (Sat, 08 Feb 2020)
Log Message
[LFC][BFC] Box::isFloatAvoider should not check for isFloatingPositioned()
https://bugs.webkit.org/show_bug.cgi?id=207429
<rdar://problem/59288204>
Reviewed by Antti Koivisto.
Box::isFloatAvoider() already checks for establishesBlockFormattingContext() (and floats do establish BFCs).
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isFloatAvoider const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (256093 => 256094)
--- trunk/Source/WebCore/ChangeLog 2020-02-08 21:50:02 UTC (rev 256093)
+++ trunk/Source/WebCore/ChangeLog 2020-02-08 21:54:58 UTC (rev 256094)
@@ -1,3 +1,16 @@
+2020-02-08 Zalan Bujtas <[email protected]>
+
+ [LFC][BFC] Box::isFloatAvoider should not check for isFloatingPositioned()
+ https://bugs.webkit.org/show_bug.cgi?id=207429
+ <rdar://problem/59288204>
+
+ Reviewed by Antti Koivisto.
+
+ Box::isFloatAvoider() already checks for establishesBlockFormattingContext() (and floats do establish BFCs).
+
+ * layout/layouttree/LayoutBox.cpp:
+ (WebCore::Layout::Box::isFloatAvoider const):
+
2020-02-08 Sam Weinig <[email protected]>
Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
Modified: trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp (256093 => 256094)
--- trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp 2020-02-08 21:50:02 UTC (rev 256093)
+++ trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp 2020-02-08 21:54:58 UTC (rev 256094)
@@ -194,7 +194,7 @@
bool Box::isFloatAvoider() const
{
- return establishesBlockFormattingContext() || establishesTableFormattingContext() || isFloatingPositioned() || hasFloatClear();
+ return establishesBlockFormattingContext() || establishesTableFormattingContext() || hasFloatClear();
}
const Container* Box::containingBlock() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
