Title: [103700] trunk/Source/WebKit2
- Revision
- 103700
- Author
- [email protected]
- Date
- 2011-12-26 22:27:03 -0800 (Mon, 26 Dec 2011)
Log Message
<http://webkit.org/b/75196> REGRESSION(r103643): Command-clicking a link no longer opens a new tab.
r103643 contained some botched copy-paste code that caused the state of the Command key
to be lost when translating from a WebKit2 event to a WebCore event.
Reviewed by Dan Bernstein.
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): Test for the correct modifier.
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): Ditto.
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent): Ditto.
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Ditto.
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (103699 => 103700)
--- trunk/Source/WebKit2/ChangeLog 2011-12-27 06:14:52 UTC (rev 103699)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-27 06:27:03 UTC (rev 103700)
@@ -1,3 +1,19 @@
+2011-12-26 Mark Rowe <[email protected]>
+
+ <http://webkit.org/b/75196> REGRESSION(r103643): Command-clicking a link no longer opens a new tab.
+
+ r103643 contained some botched copy-paste code that caused the state of the Command key
+ to be lost when translating from a WebKit2 event to a WebCore event.
+
+ Reviewed by Dan Bernstein.
+
+ * Shared/WebEventConversion.cpp:
+ (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): Test for the correct modifier.
+ (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): Ditto.
+ (WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent): Ditto.
+ (WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Ditto.
+ (WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent): Ditto.
+
2011-12-26 Carlos Garcia Campos <[email protected]>
Fix a crash in WebProcess when starting a download not initiated by a WebPage
Modified: trunk/Source/WebKit2/Shared/WebEventConversion.cpp (103699 => 103700)
--- trunk/Source/WebKit2/Shared/WebEventConversion.cpp 2011-12-27 06:14:52 UTC (rev 103699)
+++ trunk/Source/WebKit2/Shared/WebEventConversion.cpp 2011-12-27 06:27:03 UTC (rev 103700)
@@ -56,7 +56,7 @@
m_modifiers |= CtrlKey;
if (webEvent.altKey())
m_modifiers |= AltKey;
- if (webEvent.altKey())
+ if (webEvent.metaKey())
m_modifiers |= MetaKey;
m_timestamp = webEvent.timestamp();
@@ -90,7 +90,7 @@
m_modifierFlags |= WebEvent::ControlKey;
if (webEvent.altKey())
m_modifierFlags |= WebEvent::AltKey;
- if (webEvent.altKey())
+ if (webEvent.metaKey())
m_modifierFlags |= WebEvent::MetaKey;
#if PLATFORM(WIN)
@@ -118,7 +118,7 @@
m_modifiers |= CtrlKey;
if (webEvent.altKey())
m_modifiers |= AltKey;
- if (webEvent.altKey())
+ if (webEvent.metaKey())
m_modifiers |= MetaKey;
m_timestamp = webEvent.timestamp();
@@ -174,7 +174,7 @@
m_modifiers |= CtrlKey;
if (webEvent.altKey())
m_modifiers |= AltKey;
- if (webEvent.altKey())
+ if (webEvent.metaKey())
m_modifiers |= MetaKey;
m_timestamp = webEvent.timestamp();
@@ -224,7 +224,7 @@
m_modifiers |= CtrlKey;
if (webEvent.altKey())
m_modifiers |= AltKey;
- if (webEvent.altKey())
+ if (webEvent.metaKey())
m_modifiers |= MetaKey;
m_timestamp = webEvent.timestamp();
@@ -302,7 +302,7 @@
m_modifiers |= CtrlKey;
if (webEvent.altKey())
m_modifiers |= AltKey;
- if (webEvent.altKey())
+ if (webEvent.metaKey())
m_modifiers |= MetaKey;
m_timestamp = webEvent.timestamp();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
