Title: [256108] trunk/Source
Revision
256108
Author
[email protected]
Date
2020-02-09 18:04:36 -0800 (Sun, 09 Feb 2020)

Log Message

Re-enable LTO for ARM builds
https://bugs.webkit.org/show_bug.cgi?id=207402
<rdar://problem/49190767>

Reviewed by Sam Weinig.

Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
Enabling it for ARM was left out due to a compiler issue. That issue
has been fixed, and so now we can re-enable LTO for ARM.

Source/bmalloc:

* Configurations/Base.xcconfig:

Source/_javascript_Core:

* Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

* Configurations/Base.xcconfig:

Source/WebCore:

No new tests -- no new or changed functionality.

* Configurations/Base.xcconfig:

Source/WebCore/PAL:

* Configurations/Base.xcconfig:

Source/WebInspectorUI:

* Configurations/Base.xcconfig:

Source/WebKit:

* Configurations/Base.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/Base.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (256107 => 256108)


--- trunk/Source/_javascript_Core/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-08  Sam Weinig  <[email protected]>
 
         Move _javascript_Core related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h

Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -178,15 +178,15 @@
 WK_COCOA_TOUCH_appletvsimulator = cocoatouch;
 WK_IS_COCOA_TOUCH = $(WK_NOT_$(WK_EMPTY_$(WK_COCOA_TOUCH)));
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
+// Disable LTO for _javascript_Core, due to <rdar://problem/24543547>. Add back the following line and delete the one that says "LLVM_LTO = NO" when that issue is resolved.
+// LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 LLVM_LTO = NO;
-// Disable LTO for _javascript_Core, due to <rdar://problem/24543547>. Add back the following line when that issue is resolved.
-// LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -193,6 +193,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (256107 => 256108)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-07  Kenneth Russell  <[email protected]>
 
         Try adding glBindFramebuffer flush workaround to ANGLE as remedy for flaky WebGL tests

Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -78,14 +78,13 @@
 ANGLE_INSTALL_PATH_PREFIX_DEPLOYMENT_YES = $(ANGLE_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_USE_ALTERNATE_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 ANGLE_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_USE_ALTERNATE_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -92,6 +91,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (256107 => 256108)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-03  youenn fablet  <[email protected]>
 
         Make sure RTCVideoEncoderH264 generate a keyframe even if the frame that was supposed to be a key frame was dropped

Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -110,14 +110,13 @@
 WK_INSTALL_PATH_PREFIX = $(WK_INSTALL_PATH_PREFIX_DEPLOYMENT_$(DEPLOYMENT_LOCATION)$(WK_MACOS_1015)_USE_STAGING_INSTALL_PATH_$(USE_STAGING_INSTALL_PATH));
 WK_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_MACOS_SINCE_1015_USE_STAGING_INSTALL_PATH_YES = $(PLATFORM_OOB_SYSTEM_CONTENT_DIR);
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -124,6 +123,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/WTF/ChangeLog (256107 => 256108)


--- trunk/Source/WTF/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WTF/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-08  Sam Weinig  <[email protected]>
 
         Move _javascript_Core related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h

Modified: trunk/Source/WTF/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/WTF/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WTF/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -134,14 +134,13 @@
 OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -148,6 +147,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/WebCore/ChangeLog (256107 => 256108)


--- trunk/Source/WebCore/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebCore/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,19 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        No new tests -- no new or changed functionality.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-09  Antti Koivisto  <[email protected]>
 
         [LFC][Integration] Support intruding floats

Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/WebCore/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -143,14 +143,13 @@
 WK_WEBCORE_DERIVEDSOURCES_INPUT_XCFILELIST_ADDITIONS = $(WK_WEBKITADDITIONS_HEADERS_FOLDER_PATH)/WebCore/DerivedSources-input.xcfilelist
 WK_WEBCORE_DERIVEDSOURCES_OUTPUT_XCFILELIST_ADDITIONS = $(WK_WEBKITADDITIONS_HEADERS_FOLDER_PATH)/WebCore/DerivedSources-output.xcfilelist
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -157,6 +156,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/WebCore/PAL/ChangeLog (256107 => 256108)


--- trunk/Source/WebCore/PAL/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebCore/PAL/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-08  Sam Weinig  <[email protected]>
 
         Move _javascript_Core related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h

Modified: trunk/Source/WebCore/PAL/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/WebCore/PAL/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebCore/PAL/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -135,14 +135,13 @@
 WK_COCOA_TOUCH_appletvsimulator = cocoatouch;
 WK_IS_COCOA_TOUCH = $(WK_NOT_$(WK_EMPTY_$(WK_COCOA_TOUCH)));
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -149,6 +148,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/WebInspectorUI/ChangeLog (256107 => 256108)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-07  Jon Lee  <[email protected]>
 
         Web Inspector: Revert slim toolbar

Modified: trunk/Source/WebInspectorUI/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/WebInspectorUI/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebInspectorUI/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -107,14 +107,13 @@
 WK_COCOA_TOUCH_appletvsimulator = cocoatouch;
 WK_IS_COCOA_TOUCH = $(WK_NOT_$(WK_EMPTY_$(WK_COCOA_TOUCH)));
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -121,6 +120,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/WebKit/ChangeLog (256107 => 256108)


--- trunk/Source/WebKit/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebKit/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-09  Wenson Hsieh  <[email protected]>
 
         Fix the watchOS build after <rdar://problem/56134081>

Modified: trunk/Source/WebKit/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/WebKit/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebKit/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -157,14 +157,13 @@
 WK_WEBKIT_DERIVEDSOURCES_INPUT_XCFILELIST_ADDITIONS = $(WK_WEBKITADDITIONS_HEADERS_FOLDER_PATH)/WebKit/DerivedSources-input.xcfilelist
 WK_WEBKIT_DERIVEDSOURCES_OUTPUT_XCFILELIST_ADDITIONS = $(WK_WEBKITADDITIONS_HEADERS_FOLDER_PATH)/WebKit/DerivedSources-output.xcfilelist
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -171,6 +170,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (256107 => 256108)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-08  Sam Weinig  <[email protected]>
 
         Move _javascript_Core related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h

Modified: trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -135,14 +135,13 @@
 WK_COCOA_TOUCH_appletvsimulator = cocoatouch;
 WK_IS_COCOA_TOUCH = $(WK_NOT_$(WK_EMPTY_$(WK_COCOA_TOUCH)));
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -149,6 +148,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;

Modified: trunk/Source/bmalloc/ChangeLog (256107 => 256108)


--- trunk/Source/bmalloc/ChangeLog	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/bmalloc/ChangeLog	2020-02-10 02:04:36 UTC (rev 256108)
@@ -1,3 +1,17 @@
+2020-02-09  Keith Rollin  <[email protected]>
+
+        Re-enable LTO for ARM builds
+        https://bugs.webkit.org/show_bug.cgi?id=207402
+        <rdar://problem/49190767>
+
+        Reviewed by Sam Weinig.
+
+        Bug 190758 re-enabled LTO for Production builds for x86-family CPUs.
+        Enabling it for ARM was left out due to a compiler issue. That issue
+        has been fixed, and so now we can re-enable LTO for ARM.
+
+        * Configurations/Base.xcconfig:
+
 2020-02-08  Basuke Suzuki  <[email protected]>
 
         [bmalloc] VMHeap can be merge into Heap

Modified: trunk/Source/bmalloc/Configurations/Base.xcconfig (256107 => 256108)


--- trunk/Source/bmalloc/Configurations/Base.xcconfig	2020-02-10 01:51:43 UTC (rev 256107)
+++ trunk/Source/bmalloc/Configurations/Base.xcconfig	2020-02-10 02:04:36 UTC (rev 256108)
@@ -132,14 +132,13 @@
 BMALLOC_INSTALL_PATH_PREFIX_DEPLOYMENT_YES = $(BMALLOC_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_USE_ALTERNATE_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 BMALLOC_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_USE_ALTERNATE_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 
-// Disable on all platforms other than macOS, due to <rdar://problem/49013399>.
-LLVM_LTO = NO;
-LLVM_LTO[sdk=macosx*] = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
+LLVM_LTO = $(WK_LLVM_LTO_$(WK_XCODE_SUPPORTS_LTO));
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
 WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_VERSION_BEFORE_10_2_0700 = YES;
+WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000 = $(WK_XCODE_VERSION_BEFORE_10_2_1000_$(XCODE_VERSION_MINOR));
@@ -146,6 +145,15 @@
 WK_XCODE_VERSION_BEFORE_10_2_1000_1000 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_1000_1010 = YES;
 
+WK_XCODE_VERSION_BEFORE_11_4_0800 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_0900 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1000 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100 = $(WK_XCODE_VERSION_BEFORE_11_4_1100_$(XCODE_VERSION_MINOR));
+WK_XCODE_VERSION_BEFORE_11_4_1100_1100 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1110 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1120 = YES;
+WK_XCODE_VERSION_BEFORE_11_4_1100_1130 = YES;
+
 WK_USER_LTO_MODE = $(WK_USER_LTO_MODE_$(WK_LTO_MODE));
 WK_USER_LTO_MODE_full = YES;
 WK_USER_LTO_MODE_thin = YES_THIN;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to