Title: [103710] trunk/Source/WebCore
- Revision
- 103710
- Author
- [email protected]
- Date
- 2011-12-27 08:23:26 -0800 (Tue, 27 Dec 2011)
Log Message
Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
https://bugs.webkit.org/show_bug.cgi?id=75245
Reviewed by Pavel Feldman.
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype.selectTab):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (103709 => 103710)
--- trunk/Source/WebCore/ChangeLog 2011-12-27 16:21:50 UTC (rev 103709)
+++ trunk/Source/WebCore/ChangeLog 2011-12-27 16:23:26 UTC (rev 103710)
@@ -1,3 +1,19 @@
+2011-12-27 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
+ https://bugs.webkit.org/show_bug.cgi?id=75245
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/NetworkItemView.js:
+ (WebInspector.NetworkItemView):
+ * inspector/front-end/TabbedEditorContainer.js:
+ (WebInspector.TabbedEditorContainer):
+ (WebInspector.TabbedEditorContainer.prototype._tabClosed):
+ * inspector/front-end/TabbedPane.js:
+ (WebInspector.TabbedPane.prototype.closeTab):
+ (WebInspector.TabbedPane.prototype.selectTab):
+
2011-12-27 Yury Semikhatsky <[email protected]>
Web Inspector: report per document JS event listener count
Modified: trunk/Source/WebCore/inspector/front-end/NetworkItemView.js (103709 => 103710)
--- trunk/Source/WebCore/inspector/front-end/NetworkItemView.js 2011-12-27 16:21:50 UTC (rev 103709)
+++ trunk/Source/WebCore/inspector/front-end/NetworkItemView.js 2011-12-27 16:23:26 UTC (rev 103710)
@@ -57,7 +57,7 @@
this.appendTab("timing", WebInspector.UIString("Timing"), timingView);
}
- this.addEventListener("tab-selected", this._tabSelected, this);
+ this.addEventListener(WebInspector.TabbedPane.EventTypes.TabSelected, this._tabSelected, this);
}
WebInspector.NetworkItemView.prototype = {
Modified: trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js (103709 => 103710)
--- trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js 2011-12-27 16:21:50 UTC (rev 103709)
+++ trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js 2011-12-27 16:23:26 UTC (rev 103710)
@@ -36,6 +36,8 @@
this._tabbedPane.closeableTabs = true;
this._tabbedPane.element.id = "scripts-editor-container-tabbed-pane";
+ this._tabbedPane.addEventListener(WebInspector.TabbedPane.EventTypes.TabClosed, this._tabClosed, this);
+
this._titles = new Map();
this._tabIds = new Map();
}
@@ -90,14 +92,21 @@
{
var tabId = this._tabIds.get(sourceFrame);
- if (tabId) {
+ if (tabId)
this._tabbedPane.closeTab(tabId);
- this._tabIds.remove(sourceFrame);
- this._titles.remove(sourceFrame);
- }
},
/**
+ * @param {Event} event
+ */
+ _tabClosed: function(event)
+ {
+ var sourceFrame = /** @type {WebInspector.UISourceCode} */ event.data.view;
+ this._tabIds.remove(sourceFrame);
+ this._titles.remove(sourceFrame);
+ },
+
+ /**
* @param {string} title
* @param {WebInspector.SourceFrame} sourceFrame
*/
Modified: trunk/Source/WebCore/inspector/front-end/TabbedPane.js (103709 => 103710)
--- trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2011-12-27 16:21:50 UTC (rev 103709)
+++ trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2011-12-27 16:23:26 UTC (rev 103710)
@@ -48,6 +48,11 @@
this._dropDownButton = this._createDropDownButton();
}
+WebInspector.TabbedPane.EventTypes = {
+ TabSelected: "TabSelected",
+ TabClosed: "TabClosed"
+}
+
WebInspector.TabbedPane.prototype = {
/**
* @type {WebInspector.View}
@@ -118,6 +123,8 @@
else
this._updateTabElements();
+ var eventData = { tabId: id, view: tab.view, isUserGesture: userGesture };
+ this.dispatchEventToListeners(WebInspector.TabbedPane.EventTypes.TabClosed, eventData);
return true;
},
@@ -148,8 +155,8 @@
this._updateTabElements();
- var event = {tabId: id, view: tab.view, isUserGesture: userGesture};
- this.dispatchEventToListeners("tab-selected", event);
+ var eventData = { tabId: id, view: tab.view, isUserGesture: userGesture };
+ this.dispatchEventToListeners(WebInspector.TabbedPane.EventTypes.TabSelected, eventData);
return true;
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
