Title: [256206] trunk/Tools
- Revision
- 256206
- Author
- [email protected]
- Date
- 2020-02-10 13:14:39 -0800 (Mon, 10 Feb 2020)
Log Message
[ews] Use SetBuildSummary instead of buildFinished in Layout tests
https://bugs.webkit.org/show_bug.cgi?id=207492
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(RunWebKitTests.evaluateCommand):
(ReRunWebKitTests.evaluateCommand):
(AnalyzeLayoutTestsResults.report_pre_existing_failures):
* BuildSlaveSupport/ews-build/factories.py:
(TestFactory.__init__):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (256205 => 256206)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2020-02-10 21:06:45 UTC (rev 256205)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2020-02-10 21:14:39 UTC (rev 256206)
@@ -113,6 +113,7 @@
self.addStep(KillOldProcesses())
if self.LayoutTestClass:
self.addStep(self.LayoutTestClass())
+ self.addStep(SetBuildSummary())
if self.APITestClass:
self.addStep(self.APITestClass())
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (256205 => 256206)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-02-10 21:06:45 UTC (rev 256205)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-02-10 21:14:39 UTC (rev 256206)
@@ -1434,7 +1434,7 @@
message = 'Passed layout tests'
self.descriptionDone = message
self.build.results = SUCCESS
- self.build.buildFinished([message], SUCCESS)
+ self.setProperty('build_summary', message)
else:
self.build.addStepsAfterCurrentStep([
ArchiveTestResults(),
@@ -1475,7 +1475,7 @@
self.build.results = SUCCESS
if not first_results_did_exceed_test_failure_limit:
message = 'Found flaky tests: {}'.format(flaky_failures_string)
- self.build.buildFinished([message], SUCCESS)
+ self.setProperty('build_summary', message)
else:
self.setProperty('patchFailedTests', True)
self.build.addStepsAfterCurrentStep([ArchiveTestResults(),
@@ -1545,7 +1545,7 @@
pluralSuffix = 's' if len(clean_tree_failures) > 1 else ''
clean_tree_failures_string = ', '.join([failure_name for failure_name in clean_tree_failures])
message = 'Found {} pre-existing test failure{}: {}'.format(len(clean_tree_failures), pluralSuffix, clean_tree_failures_string)
- self.build.buildFinished([message], SUCCESS)
+ self.setProperty('build_summary', message)
return defer.succeed(None)
def retry_build(self, message=''):
Modified: trunk/Tools/ChangeLog (256205 => 256206)
--- trunk/Tools/ChangeLog 2020-02-10 21:06:45 UTC (rev 256205)
+++ trunk/Tools/ChangeLog 2020-02-10 21:14:39 UTC (rev 256206)
@@ -1,3 +1,17 @@
+2020-02-10 Aakash Jain <[email protected]>
+
+ [ews] Use SetBuildSummary instead of buildFinished in Layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=207492
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (RunWebKitTests.evaluateCommand):
+ (ReRunWebKitTests.evaluateCommand):
+ (AnalyzeLayoutTestsResults.report_pre_existing_failures):
+ * BuildSlaveSupport/ews-build/factories.py:
+ (TestFactory.__init__):
+
2020-02-10 Truitt Savell <[email protected]>
Unreviewed, rolling out r256091.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
