Title: [256233] trunk/Source/WebKit
- Revision
- 256233
- Author
- [email protected]
- Date
- 2020-02-10 17:13:01 -0800 (Mon, 10 Feb 2020)
Log Message
WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
<https://webkit.org/b/207519>
<rdar://problem/59043436>
Reviewed by Brent Fulgham.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::initializeClassesForParameterCoding):
- Change `className` to keep a copy of the CString object.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (256232 => 256233)
--- trunk/Source/WebKit/ChangeLog 2020-02-11 00:53:36 UTC (rev 256232)
+++ trunk/Source/WebKit/ChangeLog 2020-02-11 01:13:01 UTC (rev 256233)
@@ -1,3 +1,15 @@
+2020-02-10 David Kilzer <[email protected]>
+
+ WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
+ <https://webkit.org/b/207519>
+ <rdar://problem/59043436>
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::initializeClassesForParameterCoding):
+ - Change `className` to keep a copy of the CString object.
+
2020-02-10 Per Arne Vollan <[email protected]>
[watchOS] Notification listener is never unregistered
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (256232 => 256233)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-02-11 00:53:36 UTC (rev 256232)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-02-11 01:13:01 UTC (rev 256233)
@@ -712,10 +712,10 @@
auto mutableSet = adoptNS([standardClasses mutableCopy]);
for (const auto& customClass : customClasses) {
- const auto* className = customClass.utf8().data();
- Class objectClass = objc_lookUpClass(className);
+ auto className = customClass.utf8();
+ Class objectClass = objc_lookUpClass(className.data());
if (!objectClass) {
- WTFLogAlways("InjectedBundle::extendClassesForParameterCoder - Class %s is not a valid Objective C class.\n", className);
+ WTFLogAlways("InjectedBundle::extendClassesForParameterCoder - Class %s is not a valid Objective C class.\n", className.data());
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes