Log Message
bidi-override-in-anonymous-block.html is failing https://bugs.webkit.org/show_bug.cgi?id=74688
Unreviewed. This test just needs an updated expectation. The case that changed is the last (in the HTML) Ruby case. That tests an <rt> element nested inside an <rb> element. Previously, the <rt> element closed the <rb> element, but the HTML5 spec changed the parser so that the <rt> does not close the <rb>. I don't fully understand the issues, but the discussion on the mailing list makes it sound like this is the better way to parse Ruby. In any case, the change in parsing behavior changed how we render this test case. The bidi aspect are still functioning correctly. * platform/chromium/test_expectations.txt: * platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt: * platform/mac/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (103718 => 103719)
--- trunk/LayoutTests/ChangeLog 2011-12-27 19:12:58 UTC (rev 103718)
+++ trunk/LayoutTests/ChangeLog 2011-12-27 19:36:01 UTC (rev 103719)
@@ -1,3 +1,25 @@
+2011-12-27 Adam Barth <[email protected]>
+
+ bidi-override-in-anonymous-block.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=74688
+
+ Unreviewed.
+
+ This test just needs an updated expectation. The case that changed is
+ the last (in the HTML) Ruby case. That tests an <rt> element nested
+ inside an <rb> element. Previously, the <rt> element closed the <rb>
+ element, but the HTML5 spec changed the parser so that the <rt> does
+ not close the <rb>. I don't fully understand the issues, but the
+ discussion on the mailing list makes it sound like this is the better
+ way to parse Ruby.
+
+ In any case, the change in parsing behavior changed how we render this
+ test case. The bidi aspect are still functioning correctly.
+
+ * platform/chromium/test_expectations.txt:
+ * platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
+ * platform/mac/test_expectations.txt:
+
2011-12-27 Ryosuke Niwa <[email protected]>
Chromium rebaseline after r103251.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (103718 => 103719)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-27 19:12:58 UTC (rev 103718)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-12-27 19:36:01 UTC (rev 103719)
@@ -4010,6 +4010,7 @@
BUGWK74634 WIN : compositing/absolute-position-changed-with-composited-parent-layer.html = IMAGE
+// Needs a new baseline. See https://bugs.webkit.org/show_bug.cgi?id=74688
BUGWK74688 : fast/css/bidi-override-in-anonymous-block.html = TEXT
BUGWK74731 : compositing/reflections/reflection-positioning2.html = PASS IMAGE
Modified: trunk/LayoutTests/platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt (103718 => 103719)
--- trunk/LayoutTests/platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt 2011-12-27 19:12:58 UTC (rev 103718)
+++ trunk/LayoutTests/platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt 2011-12-27 19:36:01 UTC (rev 103719)
@@ -113,49 +113,49 @@
text run at (0,0) width 29: "ruby"
RenderBlock {DIV} at (0,866) size 769x30 [border: (1px solid #000000)]
RenderRuby (inline) {RUBY} at (0,0) size 22x18
- RenderRubyRun (anonymous) at (160,11) size 22x18
+ RenderRubyRun (anonymous) at (180,11) size 22x18
RenderRubyText {RT} at (0,-10) size 22x10
RenderText {#text} at (5,0) size 12x10
text run at (5,0) width 12: "def"
RenderRubyBase (anonymous) at (0,0) size 22x18
RenderText {#text} at (0,0) size 22x18
text run at (0,0) width 22 RTL override: "abc"
- RenderText {#text} at (155,11) size 4x18
- text run at (155,11) width 4 RTL: " "
+ RenderText {#text} at (175,11) size 4x18
+ text run at (175,11) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 22x18
- RenderRubyRun (anonymous) at (132,11) size 22x18
+ RenderRubyRun (anonymous) at (152,11) size 22x18
RenderRubyText {RT} at (0,-10) size 22x10
RenderText {#text} at (5,0) size 12x10
text run at (5,0) width 12 RTL override: "def"
RenderRubyBase (anonymous) at (0,0) size 22x18
RenderText {#text} at (0,0) size 22x18
text run at (0,0) width 22 RTL override: "abc"
- RenderText {#text} at (127,11) size 4x18
- text run at (127,11) width 4 RTL: " "
+ RenderText {#text} at (147,11) size 4x18
+ text run at (147,11) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 22x18
- RenderRubyRun (anonymous) at (104,11) size 22x18
+ RenderRubyRun (anonymous) at (124,11) size 22x18
RenderRubyBase (anonymous) at (0,0) size 22x18
RenderText {#text} at (0,0) size 22x18
text run at (0,0) width 22 RTL override: "abc"
- RenderText {#text} at (99,11) size 4x18
- text run at (99,11) width 4 RTL: " "
+ RenderText {#text} at (119,11) size 4x18
+ text run at (119,11) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 12x18
- RenderRubyRun (anonymous) at (86,27) size 12x0
+ RenderRubyRun (anonymous) at (106,27) size 12x0
RenderRubyText {RT} at (0,-10) size 12x10
RenderText {#text} at (0,0) size 12x10
text run at (0,0) width 12: "def"
- RenderText {#text} at (81,11) size 4x18
- text run at (81,11) width 4 RTL: " "
+ RenderText {#text} at (101,11) size 4x18
+ text run at (101,11) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 22x18
- RenderRubyRun (anonymous) at (58,11) size 22x18
+ RenderRubyRun (anonymous) at (78,11) size 22x18
RenderRubyBase (anonymous) at (0,0) size 22x18
RenderInline {RB} at (0,0) size 22x18
RenderText {#text} at (0,0) size 22x18
text run at (0,0) width 22 RTL override: "abc"
- RenderText {#text} at (53,11) size 4x18
- text run at (53,11) width 4 RTL: " "
+ RenderText {#text} at (73,11) size 4x18
+ text run at (73,11) width 4 RTL: " "
RenderRuby (inline) {RUBY} at (0,0) size 22x18
- RenderRubyRun (anonymous) at (30,11) size 22x18
+ RenderRubyRun (anonymous) at (50,11) size 22x18
RenderRubyText {RT} at (0,-10) size 22x10
RenderText {#text} at (5,0) size 12x10
text run at (5,0) width 12: "def"
@@ -163,17 +163,17 @@
RenderInline {RB} at (0,0) size 22x18
RenderText {#text} at (0,0) size 22x18
text run at (0,0) width 22 RTL override: "abc"
- RenderText {#text} at (25,11) size 4x18
- text run at (25,11) width 4 RTL: " "
- RenderRuby (inline) {RUBY} at (0,0) size 22x18
- RenderRubyRun (anonymous) at (2,11) size 22x18
- RenderRubyText {RT} at (0,-10) size 22x10
- RenderText {#text} at (5,0) size 12x10
- text run at (5,0) width 12: "def"
- RenderRubyBase (anonymous) at (0,0) size 22x18
- RenderInline {RB} at (0,0) size 22x18
- RenderText {#text} at (0,0) size 22x18
- text run at (0,0) width 22 RTL override: "abc"
+ RenderText {#text} at (45,11) size 4x18
+ text run at (45,11) width 4 RTL: " "
+ RenderRuby (inline) {RUBY} at (0,0) size 42x18
+ RenderRubyRun (anonymous) at (2,11) size 42x18
+ RenderRubyBase (anonymous) at (0,0) size 42x18
+ RenderInline {RB} at (0,0) size 42x18
+ RenderText {#text} at (20,0) size 22x18
+ text run at (20,0) width 22 RTL override: "abc"
+ RenderInline {RT} at (0,0) size 20x18
+ RenderText {#text} at (0,0) size 20x18
+ text run at (0,0) width 20 RTL override: "def"
RenderText {#text} at (0,0) size 0x0
RenderBlock {P} at (0,912) size 769x18
RenderText {#text} at (0,0) size 417x18
Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (103718 => 103719)
--- trunk/LayoutTests/platform/mac/test_expectations.txt 2011-12-27 19:12:58 UTC (rev 103718)
+++ trunk/LayoutTests/platform/mac/test_expectations.txt 2011-12-27 19:36:01 UTC (rev 103719)
@@ -92,4 +92,3 @@
BUGWK74432 : fast/borders/border-antialiasing.html = IMAGE
BUGWK75235 : media/video-scales-in-media-document.html = TEXT
-BUGWK75236 : fast/css/bidi-override-in-anonymous-block.html = TEXT
_______________________________________________ webkit-changes mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
