Title: [103722] trunk/Source
Revision
103722
Author
[email protected]
Date
2011-12-27 12:13:11 -0800 (Tue, 27 Dec 2011)

Log Message

[chromium] really enable wpo for WebCore libs and for WTF
https://bugs.webkit.org/show_bug.cgi?id=75264

Reviewed by Adam Barth.

Source/_javascript_Core:

* _javascript_Core.gyp/_javascript_Core.gyp: Enable WPO for wtf and yarr.

Source/WebCore:

* WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the
value set in common.gypi.  Use a target_defaults instead to set the
variable.  I tested manually on my Windows machine and
WholeProgramOptimization is getting set when buildtype is Official.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (103721 => 103722)


--- trunk/Source/_javascript_Core/ChangeLog	2011-12-27 19:53:18 UTC (rev 103721)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-27 20:13:11 UTC (rev 103722)
@@ -1,3 +1,12 @@
+2011-12-27  Tony Chang  <[email protected]>
+
+        [chromium] really enable wpo for WebCore libs and for WTF
+        https://bugs.webkit.org/show_bug.cgi?id=75264
+
+        Reviewed by Adam Barth.
+
+        * _javascript_Core.gyp/_javascript_Core.gyp: Enable WPO for wtf and yarr.
+
 2011-12-26  Gavin Barraclough  <[email protected]>
 
         Errk! OS X build fix.

Modified: trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp (103721 => 103722)


--- trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2011-12-27 19:53:18 UTC (rev 103721)
+++ trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2011-12-27 20:13:11 UTC (rev 103722)
@@ -104,6 +104,7 @@
       'target_name': 'wtf',
       'type': 'static_library',
       'msvs_guid': 'AA8A5A85-592B-4357-BC60-E0E91E026AF6',
+      'variables': { 'optimize': 'max' },
       'dependencies': [
         'wtf_config',
         '<(chromium_src_dir)/third_party/icu/icu.gyp:icui18n',
@@ -205,6 +206,7 @@
         }],
       ],
       'msvs_guid': '49909552-0B0C-4C14-8CF6-DB8A2ADE0934',
+      'variables': { 'optimize': 'max' },
       'actions': [
         {
           'action_name': 'retgen',

Modified: trunk/Source/WebCore/ChangeLog (103721 => 103722)


--- trunk/Source/WebCore/ChangeLog	2011-12-27 19:53:18 UTC (rev 103721)
+++ trunk/Source/WebCore/ChangeLog	2011-12-27 20:13:11 UTC (rev 103722)
@@ -1,5 +1,17 @@
 2011-12-27  Tony Chang  <[email protected]>
 
+        [chromium] really enable wpo for WebCore libs and for WTF
+        https://bugs.webkit.org/show_bug.cgi?id=75264
+
+        Reviewed by Adam Barth.
+
+        * WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the
+        value set in common.gypi.  Use a target_defaults instead to set the
+        variable.  I tested manually on my Windows machine and
+        WholeProgramOptimization is getting set when buildtype is Official.
+
+2011-12-27  Tony Chang  <[email protected]>
+
         [chromium] remove references to files no longer in the tree
         https://bugs.webkit.org/show_bug.cgi?id=75262
 

Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (103721 => 103722)


--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-12-27 19:53:18 UTC (rev 103721)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-12-27 20:13:11 UTC (rev 103722)
@@ -45,7 +45,6 @@
     # binary and increasing the speed of gdb.
     'enable_svg%': 1,
 
-    'optimize': 'max',
     'enable_wexit_time_destructors': 1,
 
     'webcore_include_dirs': [
@@ -262,6 +261,12 @@
     ],
   },  # variables
 
+  'target_defaults': {
+    'variables': {
+      'optimize': 'max',
+    },
+  },
+
   'conditions': [
     ['OS!="win" and remove_webcore_debug_symbols==1', {
       # Remove -g from all targets defined here.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to