Title: [256300] trunk/LayoutTests
Revision
256300
Author
[email protected]
Date
2020-02-11 03:31:58 -0800 (Tue, 11 Feb 2020)

Log Message

REGRESSION: [ Mac ] legacy-animation-engine/fast/animation/request-animation-frame-iframe2.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206624

Patch by Said Abou-Hallawa <[email protected]> on 2020-02-11
Reviewed by Antoine Quint.

Rewrite test to have a reliable asynchronous execution order.

* fast/animation/script-tests/request-animation-frame-subframe.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (256299 => 256300)


--- trunk/LayoutTests/ChangeLog	2020-02-11 10:47:26 UTC (rev 256299)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 11:31:58 UTC (rev 256300)
@@ -1,3 +1,14 @@
+2020-02-11  Said Abou-Hallawa  <[email protected]>
+
+        REGRESSION: [ Mac ] legacy-animation-engine/fast/animation/request-animation-frame-iframe2.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=206624
+
+        Reviewed by Antoine Quint.
+
+        Rewrite test to have a reliable asynchronous execution order.
+
+        * fast/animation/script-tests/request-animation-frame-subframe.html:
+
 2020-02-11  Chris Lord  <[email protected]>
 
         [GTK][WPE] imported/w3c/web-platform-tests/css/css-lists/counter-* tests consistently pass

Modified: trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html (256299 => 256300)


--- trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html	2020-02-11 10:47:26 UTC (rev 256299)
+++ trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html	2020-02-11 11:31:58 UTC (rev 256300)
@@ -7,17 +7,24 @@
 <script>
     window.requestAnimationFrame(function() {
         parent.callbackInvoked = true;
+        doWork();
     });
 
-    parent.doDisplay();
-    
-    setTimeout(function() {
+    function timeoutPromise(interval) {
+        return new Promise((resolve, reject) => {
+            setTimeout(function(){
+                resolve("done");
+            }, interval);
+        });
+    }
+
+    async function doWork() {
+        parent.doDisplay();
+        await timeoutPromise(100);
         parent.doCheckResult();
-    }, 100);
-
-    setTimeout(function() {
+        await timeoutPromise(100);
         parent.doTestDone();
-    }, 200);    
+    }   
 </script>
 </body>
 </html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to