Title: [103727] trunk/Source
- Revision
- 103727
- Author
- [email protected]
- Date
- 2011-12-27 14:04:20 -0800 (Tue, 27 Dec 2011)
Log Message
[chromium] When building with clang, enable -Wglobal-constructors
https://bugs.webkit.org/show_bug.cgi?id=74365
Reviewed by Adam Barth.
Source/WebCore:
* WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
* WebKit.gyp: Only add it to the webkit target. I got errors when
trying to compile webkit_unit_tests.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (103726 => 103727)
--- trunk/Source/WebCore/ChangeLog 2011-12-27 21:39:43 UTC (rev 103726)
+++ trunk/Source/WebCore/ChangeLog 2011-12-27 22:04:20 UTC (rev 103727)
@@ -1,5 +1,14 @@
2011-12-27 Tony Chang <[email protected]>
+ [chromium] When building with clang, enable -Wglobal-constructors
+ https://bugs.webkit.org/show_bug.cgi?id=74365
+
+ Reviewed by Adam Barth.
+
+ * WebCore.gyp/WebCore.gyp:
+
+2011-12-27 Tony Chang <[email protected]>
+
[chromium] really enable wpo for WebCore libs and for WTF
https://bugs.webkit.org/show_bug.cgi?id=75264
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (103726 => 103727)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-12-27 21:39:43 UTC (rev 103726)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-12-27 22:04:20 UTC (rev 103727)
@@ -339,6 +339,14 @@
}, # target webkit_system_interface
], # targets
}], # condition OS == "mac"
+ ['clang==1', {
+ 'target_defaults': {
+ 'cflags': ['-Wglobal-constructors'],
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': ['-Wglobal-constructors'],
+ },
+ },
+ }],
], # conditions
'targets': [
Modified: trunk/Source/WebKit/chromium/ChangeLog (103726 => 103727)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-27 21:39:43 UTC (rev 103726)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-27 22:04:20 UTC (rev 103727)
@@ -1,3 +1,13 @@
+2011-12-27 Tony Chang <[email protected]>
+
+ [chromium] When building with clang, enable -Wglobal-constructors
+ https://bugs.webkit.org/show_bug.cgi?id=74365
+
+ Reviewed by Adam Barth.
+
+ * WebKit.gyp: Only add it to the webkit target. I got errors when
+ trying to compile webkit_unit_tests.
+
2011-12-24 Ryosuke Niwa <[email protected]>
Unreviewed, rolling out r103619.
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (103726 => 103727)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2011-12-27 21:39:43 UTC (rev 103726)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2011-12-27 22:04:20 UTC (rev 103727)
@@ -841,6 +841,12 @@
}],
],
}],
+ ['clang==1', {
+ 'cflags': ['-Wglobal-constructors'],
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': ['-Wglobal-constructors'],
+ },
+ }],
],
},
{
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
