Title: [103730] trunk/Source/WebCore
- Revision
- 103730
- Author
- [email protected]
- Date
- 2011-12-27 14:49:51 -0800 (Tue, 27 Dec 2011)
Log Message
[Chromium] uninitialized variable in fakeMouseMoveEventTimerFired
https://bugs.webkit.org/show_bug.cgi?id=75263
Reviewed by Tony Chang.
The failure was caused by PlatformKeyboardEvent::getCurrentModifierState in PlatformKeyboardEventChromium.cpp
not initializing arguments on Linux. Fixed the failure by always assigning false to the arguments.
But we should really fix this function for Linux. Not recognizing any modifier isn't great.
* platform/chromium/PlatformKeyboardEventChromium.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (103729 => 103730)
--- trunk/Source/WebCore/ChangeLog 2011-12-27 22:31:45 UTC (rev 103729)
+++ trunk/Source/WebCore/ChangeLog 2011-12-27 22:49:51 UTC (rev 103730)
@@ -1,3 +1,18 @@
+2011-12-27 Ryosuke Niwa <[email protected]>
+
+ [Chromium] uninitialized variable in fakeMouseMoveEventTimerFired
+ https://bugs.webkit.org/show_bug.cgi?id=75263
+
+ Reviewed by Tony Chang.
+
+ The failure was caused by PlatformKeyboardEvent::getCurrentModifierState in PlatformKeyboardEventChromium.cpp
+ not initializing arguments on Linux. Fixed the failure by always assigning false to the arguments.
+
+ But we should really fix this function for Linux. Not recognizing any modifier isn't great.
+
+ * platform/chromium/PlatformKeyboardEventChromium.cpp:
+ (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
+
2011-12-27 Kentaro Hara <[email protected]>
WIP: Enable the [Supplemental] IDL on Gtk
Modified: trunk/Source/WebCore/platform/chromium/PlatformKeyboardEventChromium.cpp (103729 => 103730)
--- trunk/Source/WebCore/platform/chromium/PlatformKeyboardEventChromium.cpp 2011-12-27 22:31:45 UTC (rev 103729)
+++ trunk/Source/WebCore/platform/chromium/PlatformKeyboardEventChromium.cpp 2011-12-27 22:49:51 UTC (rev 103730)
@@ -100,6 +100,10 @@
altKey = currentModifiers & ::optionKey;
metaKey = currentModifiers & ::cmdKey;
#else
+ shiftKey = false;
+ ctrlKey = false;
+ altKey = false;
+ metaKey = false;
notImplemented();
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
