Title: [256402] branches/safari-609-branch/LayoutTests
Revision
256402
Author
[email protected]
Date
2020-02-11 16:59:29 -0800 (Tue, 11 Feb 2020)

Log Message

Cherry-pick r255825. rdar://problem/59299127

    REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing
    https://bugs.webkit.org/show_bug.cgi?id=207194
    <rdar://problem/59148073>

    Reviewed by Wenson Hsieh.

    Test was flaky because it relied on a 10ms timer.

    * fast/scrolling/ios/scroll-events-back-forward-expected.txt:
    * fast/scrolling/ios/scroll-events-back-forward.html:
    * platform/ios-wk2/TestExpectations:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256401 => 256402)


--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-12 00:49:58 UTC (rev 256401)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-12 00:59:29 UTC (rev 256402)
@@ -1,5 +1,37 @@
 2020-02-11  Alan Coon  <[email protected]>
 
+        Cherry-pick r255825. rdar://problem/59299127
+
+    REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing
+    https://bugs.webkit.org/show_bug.cgi?id=207194
+    <rdar://problem/59148073>
+    
+    Reviewed by Wenson Hsieh.
+    
+    Test was flaky because it relied on a 10ms timer.
+    
+    * fast/scrolling/ios/scroll-events-back-forward-expected.txt:
+    * fast/scrolling/ios/scroll-events-back-forward.html:
+    * platform/ios-wk2/TestExpectations:
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-02-05  Chris Dumez  <[email protected]>
+
+            REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing
+            https://bugs.webkit.org/show_bug.cgi?id=207194
+            <rdar://problem/59148073>
+
+            Reviewed by Wenson Hsieh.
+
+            Test was flaky because it relied on a 10ms timer.
+
+            * fast/scrolling/ios/scroll-events-back-forward-expected.txt:
+            * fast/scrolling/ios/scroll-events-back-forward.html:
+            * platform/ios-wk2/TestExpectations:
+
+2020-02-11  Alan Coon  <[email protected]>
+
         Cherry-pick r255162. rdar://problem/59299120
 
     Support 'allow="fullscreen"' feature policy

Modified: branches/safari-609-branch/LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt (256401 => 256402)


--- branches/safari-609-branch/LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt	2020-02-12 00:49:58 UTC (rev 256401)
+++ branches/safari-609-branch/LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt	2020-02-12 00:59:29 UTC (rev 256402)
@@ -5,7 +5,7 @@
 
 pageshow 0
 pageshow 1
-PASS scrollEventCount is 1
+PASS scrollEventCount became 1
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: branches/safari-609-branch/LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html (256401 => 256402)


--- branches/safari-609-branch/LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html	2020-02-12 00:49:58 UTC (rev 256401)
+++ branches/safari-609-branch/LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html	2020-02-12 00:59:29 UTC (rev 256402)
@@ -2,7 +2,7 @@
 <!DOCTYPE html>
 <html>
 <head>
-  <script src=""
+  <script src=""
   <style>
     body {
       height: 2000px;
@@ -10,11 +10,9 @@
   </style>
 </head>
 <body>
-<p id="description"></p>
-<div id="console"></div>
-
 <script>
 description('Tests that scroll event listeners still work after going back to a page in the page cache.');
+jsTestIsAsync = true;
 
 function testScrollListener(message)
 {
@@ -32,11 +30,8 @@
   debug('pageshow ' + pageShowCount);
   if (++pageShowCount == 2) {
       testScrollListener('After going back');
-      window.setTimeout(function() {
-        shouldBe('scrollEventCount', '1');
-        finishJSTest();
-      }, 10);
-    }
+      shouldBecomeEqual('scrollEventCount', '1', finishJSTest);
+  }
 }
 
 function onPageLoad()
@@ -49,11 +44,6 @@
 
 window.addEventListener('load', onPageLoad, false);
 window.addEventListener('pageshow', onPageShow, false);
-
-var successfullyParsed = true;
-var jsTestIsAsync = true;
 </script> 
-
-<script src=""
 </body>
 </html>

Modified: branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations (256401 => 256402)


--- branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-12 00:49:58 UTC (rev 256401)
+++ branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-12 00:59:29 UTC (rev 256402)
@@ -1351,4 +1351,3 @@
 
 webkit.org/b/205308 accessibility/smart-invert-reference.html [ ImageOnlyFailure ]
 
-webkit.org/b/207194 fast/scrolling/ios/scroll-events-back-forward.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to