Title: [256412] branches/safari-609-branch/Source/WebCore
- Revision
- 256412
- Author
- [email protected]
- Date
- 2020-02-11 17:00:13 -0800 (Tue, 11 Feb 2020)
Log Message
Cherry-pick r255562. rdar://problem/59299120
Do not copy feature policy in isFeaturePolicyAllowedByDocumentAndAllOwners
https://bugs.webkit.org/show_bug.cgi?id=207110
Reviewed by Eric Carlson.
Use auto& instead of auto to not copy the feature policy object.
Add some auto* to improve code readability.
No change of behavior.
* html/FeaturePolicy.cpp:
(WebCore::isFeaturePolicyAllowedByDocumentAndAllOwners):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (256411 => 256412)
--- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-12 01:00:10 UTC (rev 256411)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-12 01:00:13 UTC (rev 256412)
@@ -1,5 +1,38 @@
2020-02-11 Alan Coon <[email protected]>
+ Cherry-pick r255562. rdar://problem/59299120
+
+ Do not copy feature policy in isFeaturePolicyAllowedByDocumentAndAllOwners
+ https://bugs.webkit.org/show_bug.cgi?id=207110
+
+ Reviewed by Eric Carlson.
+
+ Use auto& instead of auto to not copy the feature policy object.
+ Add some auto* to improve code readability.
+ No change of behavior.
+
+ * html/FeaturePolicy.cpp:
+ (WebCore::isFeaturePolicyAllowedByDocumentAndAllOwners):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-02-03 youenn fablet <[email protected]>
+
+ Do not copy feature policy in isFeaturePolicyAllowedByDocumentAndAllOwners
+ https://bugs.webkit.org/show_bug.cgi?id=207110
+
+ Reviewed by Eric Carlson.
+
+ Use auto& instead of auto to not copy the feature policy object.
+ Add some auto* to improve code readability.
+ No change of behavior.
+
+ * html/FeaturePolicy.cpp:
+ (WebCore::isFeaturePolicyAllowedByDocumentAndAllOwners):
+
+2020-02-11 Alan Coon <[email protected]>
+
Cherry-pick r256073. rdar://problem/59299148
Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
Modified: branches/safari-609-branch/Source/WebCore/html/FeaturePolicy.cpp (256411 => 256412)
--- branches/safari-609-branch/Source/WebCore/html/FeaturePolicy.cpp 2020-02-12 01:00:10 UTC (rev 256411)
+++ branches/safari-609-branch/Source/WebCore/html/FeaturePolicy.cpp 2020-02-12 01:00:13 UTC (rev 256412)
@@ -39,14 +39,14 @@
bool isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type type, const Document& document)
{
auto& topDocument = document.topDocument();
- auto ancestorDocument = &document;
+ auto* ancestorDocument = &document;
while (ancestorDocument != &topDocument) {
if (!ancestorDocument)
return false;
- auto ownerElement = ancestorDocument->ownerElement();
+ auto* ownerElement = ancestorDocument->ownerElement();
if (is<HTMLIFrameElement>(ownerElement)) {
- auto featurePolicy = downcast<HTMLIFrameElement>(ownerElement)->featurePolicy();
+ const auto& featurePolicy = downcast<HTMLIFrameElement>(ownerElement)->featurePolicy();
if (!featurePolicy.allows(type, ancestorDocument->securityOrigin().data()))
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes