Diff
Modified: trunk/LayoutTests/ChangeLog (103745 => 103746)
--- trunk/LayoutTests/ChangeLog 2011-12-28 01:31:16 UTC (rev 103745)
+++ trunk/LayoutTests/ChangeLog 2011-12-28 02:07:26 UTC (rev 103746)
@@ -1,3 +1,16 @@
+2011-12-27 Dominic Cooney <[email protected]>
+
+ Remove initWebKitTransitionEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71701
+
+ Reviewed by Ojan Vafai.
+
+ Now that WebKitTransitionEvent has a constructor, we don't need
+ this method.
+
+ * fast/events/init-events-expected.txt:
+ * fast/events/script-tests/init-events.js:
+
2011-12-27 Ryosuke Niwa <[email protected]>
Chromium Linux CPU rebaseline after r103723.
Modified: trunk/LayoutTests/fast/events/init-events-expected.txt (103745 => 103746)
--- trunk/LayoutTests/fast/events/init-events-expected.txt 2011-12-28 01:31:16 UTC (rev 103745)
+++ trunk/LayoutTests/fast/events/init-events-expected.txt 2011-12-28 02:07:26 UTC (rev 103746)
@@ -173,15 +173,6 @@
PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').animationName is 'b'
PASS testInitEvent('WebKitAnimation', '"a", false, false, null, 1001').animationName is 'null'
PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').elapsedTime is 1001
-PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').type is 'a'
-PASS testInitEvent('WebKitTransition', 'null, false, false, "b", 1001').type is 'null'
-PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').bubbles is false
-PASS testInitEvent('WebKitTransition', '"a", true, false, "b", 1001').bubbles is true
-PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').cancelable is false
-PASS testInitEvent('WebKitTransition', '"a", false, true, "b", 1001').cancelable is true
-PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').propertyName is 'b'
-PASS testInitEvent('WebKitTransition', '"a", false, false, null, 1001').propertyName is 'null'
-PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').elapsedTime is 1001
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/events/script-tests/init-events.js (103745 => 103746)
--- trunk/LayoutTests/fast/events/script-tests/init-events.js 2011-12-28 01:31:16 UTC (rev 103745)
+++ trunk/LayoutTests/fast/events/script-tests/init-events.js 2011-12-28 02:07:26 UTC (rev 103746)
@@ -191,14 +191,4 @@
shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, null, 1001').animationName", "'null'");
shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').elapsedTime", "1001");
-shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').type", "'a'");
-shouldBe("testInitEvent('WebKitTransition', 'null, false, false, \"b\", 1001').type", "'null'");
-shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').bubbles", "false");
-shouldBe("testInitEvent('WebKitTransition', '\"a\", true, false, \"b\", 1001').bubbles", "true");
-shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').cancelable", "false");
-shouldBe("testInitEvent('WebKitTransition', '\"a\", false, true, \"b\", 1001').cancelable", "true");
-shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').propertyName", "'b'");
-shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, null, 1001').propertyName", "'null'");
-shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').elapsedTime", "1001");
-
// WheelEvent has no init function yet; roughly speaking, we are waiting for that part of DOM 3 to stabilize.
Modified: trunk/Source/WebCore/ChangeLog (103745 => 103746)
--- trunk/Source/WebCore/ChangeLog 2011-12-28 01:31:16 UTC (rev 103745)
+++ trunk/Source/WebCore/ChangeLog 2011-12-28 02:07:26 UTC (rev 103746)
@@ -1,3 +1,19 @@
+2011-12-27 Dominic Cooney <[email protected]>
+
+ Remove initWebKitTransitionEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71701
+
+ Reviewed by Ojan Vafai.
+
+ Now that WebKitTransitionEvent has a constructor, we don't need
+ this
+ method. <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15339> is
+ tracking the change to the CSS Transitions spec.
+
+ * dom/WebKitTransitionEvent.cpp:
+ * dom/WebKitTransitionEvent.h:
+ * dom/WebKitTransitionEvent.idl:
+
2011-12-27 Tony Chang <[email protected]>
Move HarfBuzz files into their own directory
Modified: trunk/Source/WebCore/dom/WebKitTransitionEvent.cpp (103745 => 103746)
--- trunk/Source/WebCore/dom/WebKitTransitionEvent.cpp 2011-12-28 01:31:16 UTC (rev 103745)
+++ trunk/Source/WebCore/dom/WebKitTransitionEvent.cpp 2011-12-28 02:07:26 UTC (rev 103746)
@@ -60,21 +60,6 @@
{
}
-void WebKitTransitionEvent::initWebKitTransitionEvent(const AtomicString& type,
- bool canBubbleArg,
- bool cancelableArg,
- const String& propertyName,
- double elapsedTime)
-{
- if (dispatched())
- return;
-
- initEvent(type, canBubbleArg, cancelableArg);
-
- m_propertyName = propertyName;
- m_elapsedTime = elapsedTime;
-}
-
const String& WebKitTransitionEvent::propertyName() const
{
return m_propertyName;
Modified: trunk/Source/WebCore/dom/WebKitTransitionEvent.h (103745 => 103746)
--- trunk/Source/WebCore/dom/WebKitTransitionEvent.h 2011-12-28 01:31:16 UTC (rev 103745)
+++ trunk/Source/WebCore/dom/WebKitTransitionEvent.h 2011-12-28 02:07:26 UTC (rev 103746)
@@ -54,12 +54,6 @@
virtual ~WebKitTransitionEvent();
- void initWebKitTransitionEvent(const AtomicString& type,
- bool canBubbleArg,
- bool cancelableArg,
- const String& propertyName,
- double elapsedTime);
-
const String& propertyName() const;
double elapsedTime() const;
Modified: trunk/Source/WebCore/dom/WebKitTransitionEvent.idl (103745 => 103746)
--- trunk/Source/WebCore/dom/WebKitTransitionEvent.idl 2011-12-28 01:31:16 UTC (rev 103745)
+++ trunk/Source/WebCore/dom/WebKitTransitionEvent.idl 2011-12-28 02:07:26 UTC (rev 103746)
@@ -28,14 +28,8 @@
interface [
ConstructorTemplate=Event
] WebKitTransitionEvent : Event {
- readonly attribute [InitializedByConstructor] DOMString propertyName;
- readonly attribute [InitializedByConstructor] double elapsedTime;
+ readonly attribute [InitializedByConstructor] DOMString propertyName;
+ readonly attribute [InitializedByConstructor] double elapsedTime;
+ };
- void initWebKitTransitionEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
- in [Optional=CallWithDefaultValue] boolean canBubbleArg,
- in [Optional=CallWithDefaultValue] boolean cancelableArg,
- in [Optional=CallWithDefaultValue] DOMString propertyNameArg,
- in [Optional=CallWithDefaultValue] double elapsedTimeArg);
-};
-
}
