Diff
Modified: trunk/LayoutTests/ChangeLog (256483 => 256484)
--- trunk/LayoutTests/ChangeLog 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/LayoutTests/ChangeLog 2020-02-12 23:03:35 UTC (rev 256484)
@@ -1,3 +1,16 @@
+2020-02-12 Truitt Savell <[email protected]>
+
+ Unreviewed, rolling out r256463.
+
+ Caused major flakiness on Mac wk2
+
+ Reverted changeset:
+
+ "REGRESSION (r255158): http/tests/frame-throttling/raf-
+ throttle-in-cross-origin-subframe.html is a flaky failure"
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+ https://trac.webkit.org/changeset/256463
+
2020-02-12 Jason Lawrence <[email protected]>
[ iOS wk2 ] http/tests/cache-storage/cache-representation.https.html is flaky timing out.
Modified: trunk/LayoutTests/fast/animation/css-animation-throttling-lowPowerMode.html (256483 => 256484)
--- trunk/LayoutTests/fast/animation/css-animation-throttling-lowPowerMode.html 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/LayoutTests/fast/animation/css-animation-throttling-lowPowerMode.html 2020-02-12 23:03:35 UTC (rev 256484)
@@ -25,6 +25,9 @@
description("Tests that CSS animations are throttled in low power mode.");
jsTestIsAsync = true;
+if (window.internals)
+ internals.settings.setRenderingUpdateThrottlingEnabled(true);
+
const element = document.getElementById("testElement");
element._onanimationstart_ = function() {
element._onanimationstart_ = null;
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-throttle-subframe.html (256483 => 256484)
--- trunk/LayoutTests/fast/animation/request-animation-frame-throttle-subframe.html 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-throttle-subframe.html 2020-02-12 23:03:35 UTC (rev 256484)
@@ -6,6 +6,9 @@
description("Tests that requestAnimationFrame is throttled in subframes that are outside the viewport");
window.jsTestIsAsync = true;
+if (window.internals)
+ internals.settings.setRenderingUpdateThrottlingEnabled(true);
+
function checkSubframesThrottled()
{
shouldBeTrue("testFrame.contentWindow.internals.isRequestAnimationFrameThrottled()");
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-throttling-detached-iframe.html (256483 => 256484)
--- trunk/LayoutTests/fast/animation/request-animation-frame-throttling-detached-iframe.html 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-throttling-detached-iframe.html 2020-02-12 23:03:35 UTC (rev 256484)
@@ -6,6 +6,9 @@
description("Test that requestAnimationFrame gets the right throttling in an iframe when inserted into a document.");
jsTestIsAsync = true;
+if (window.internals)
+ internals.settings.setRenderingUpdateThrottlingEnabled(true);
+
let i = 0;
function doWork()
{
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-throttling-lowPowerMode.html (256483 => 256484)
--- trunk/LayoutTests/fast/animation/request-animation-frame-throttling-lowPowerMode.html 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-throttling-lowPowerMode.html 2020-02-12 23:03:35 UTC (rev 256484)
@@ -6,8 +6,10 @@
description("Test that requestAnimationFrame gets throttled in low power mode.");
window.jsTestIsAsync = true;
- if (window.internals)
+ if (window.internals) {
+ internals.settings.setRenderingUpdateThrottlingEnabled(true);
internals.setLowPowerModeEnabled(true);
+ }
var start = null;
var farmesPerSecond = 0;
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-throttling-outside-viewport.html (256483 => 256484)
--- trunk/LayoutTests/fast/animation/request-animation-frame-throttling-outside-viewport.html 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-throttling-outside-viewport.html 2020-02-12 23:03:35 UTC (rev 256484)
@@ -7,6 +7,9 @@
description("Test that requestAnimationFrame gets the right throttling in an iframe when when it's outside the viewport.");
jsTestIsAsync = true;
+ if (window.internals)
+ internals.settings.setRenderingUpdateThrottlingEnabled(true);
+
var framesPerSecond = 0;
var iframeFramesPerSecond = 0;
Modified: trunk/LayoutTests/http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html (256483 => 256484)
--- trunk/LayoutTests/http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/LayoutTests/http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html 2020-02-12 23:03:35 UTC (rev 256484)
@@ -14,6 +14,9 @@
description("Tests that requestAnimationFrame is throttled in subframes that are cross-origin, and not in same-origin frames");
window.jsTestIsAsync = true;
+ if (window.internals)
+ internals.settings.setRenderingUpdateThrottlingEnabled(true);
+
var crossOriginFrame;
var sameOriginFrame
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256483 => 256484)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-12 23:03:35 UTC (rev 256484)
@@ -940,6 +940,8 @@
webkit.org/b/206961 [ Mojave ] media/media-fragments/TC0035.html [ Pass Failure ]
+webkit.org/b/206839 http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html [ Pass Failure ]
+
webkit.org/b/207003 tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html [ Pass Failure ]
webkit.org/b/207060 imported/w3c/web-platform-tests/html/webappapis/timers/type-long-setinterval.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (256483 => 256484)
--- trunk/Source/WebCore/ChangeLog 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebCore/ChangeLog 2020-02-12 23:03:35 UTC (rev 256484)
@@ -1,3 +1,16 @@
+2020-02-12 Truitt Savell <[email protected]>
+
+ Unreviewed, rolling out r256463.
+
+ Caused major flakiness on Mac wk2
+
+ Reverted changeset:
+
+ "REGRESSION (r255158): http/tests/frame-throttling/raf-
+ throttle-in-cross-origin-subframe.html is a flaky failure"
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+ https://trac.webkit.org/changeset/256463
+
2020-02-12 Yusuke Suzuki <[email protected]>
Shrink CachedResource
Modified: trunk/Source/WebCore/page/Page.cpp (256483 => 256484)
--- trunk/Source/WebCore/page/Page.cpp 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebCore/page/Page.cpp 2020-02-12 23:03:35 UTC (rev 256484)
@@ -1384,9 +1384,14 @@
bool Page::renderingUpdateThrottlingEnabled() const
{
- return !requestedLayoutMilestones().isEmpty();
+ return m_settings->renderingUpdateThrottlingEnabled();
}
+void Page::renderingUpdateThrottlingEnabledChanged()
+{
+ renderingUpdateScheduler().adjustRenderingUpdateFrequency();
+}
+
bool Page::isRenderingUpdateThrottled() const
{
return renderingUpdateThrottlingEnabled() && !m_throttlingReasons.isEmpty();
@@ -2139,11 +2144,8 @@
void Page::addLayoutMilestones(OptionSet<LayoutMilestone> milestones)
{
- bool oldRenderingUpdateThrottlingEnabled = renderingUpdateThrottlingEnabled();
// In the future, we may want a function that replaces m_layoutMilestones instead of just adding to it.
m_requestedLayoutMilestones.add(milestones);
- if (!oldRenderingUpdateThrottlingEnabled && renderingUpdateThrottlingEnabled())
- renderingUpdateScheduler().adjustRenderingUpdateFrequency();
}
void Page::removeLayoutMilestones(OptionSet<LayoutMilestone> milestones)
Modified: trunk/Source/WebCore/page/Page.h (256483 => 256484)
--- trunk/Source/WebCore/page/Page.h 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebCore/page/Page.h 2020-02-12 23:03:35 UTC (rev 256484)
@@ -702,6 +702,7 @@
WEBCORE_EXPORT void setLowPowerModeEnabledOverrideForTesting(Optional<bool>);
bool renderingUpdateThrottlingEnabled() const;
+ void renderingUpdateThrottlingEnabledChanged();
bool isRenderingUpdateThrottled() const;
Seconds preferredRenderingUpdateInterval() const;
bool canUpdateThrottlingReason(ThrottlingReason reason) const { return !m_throttlingReasonsOverridenForTesting.contains(reason); }
Modified: trunk/Source/WebCore/page/Settings.yaml (256483 => 256484)
--- trunk/Source/WebCore/page/Settings.yaml 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebCore/page/Settings.yaml 2020-02-12 23:03:35 UTC (rev 256484)
@@ -769,6 +769,10 @@
initial: false
onChange: hiddenPageCSSAnimationSuspensionEnabledChanged
+renderingUpdateThrottlingEnabled:
+ initial: true
+ onChange: renderingUpdateThrottlingEnabledChanged
+
storageBlockingPolicy:
type: SecurityOrigin::StorageBlockingPolicy
initial: SecurityOrigin::AllowAllStorage
Modified: trunk/Source/WebCore/page/SettingsBase.cpp (256483 => 256484)
--- trunk/Source/WebCore/page/SettingsBase.cpp 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebCore/page/SettingsBase.cpp 2020-02-12 23:03:35 UTC (rev 256484)
@@ -407,6 +407,12 @@
m_page->hiddenPageCSSAnimationSuspensionStateChanged();
}
+void SettingsBase::renderingUpdateThrottlingEnabledChanged()
+{
+ if (m_page)
+ m_page->renderingUpdateThrottlingEnabledChanged();
+}
+
void SettingsBase::resourceUsageOverlayVisibleChanged()
{
#if ENABLE(RESOURCE_USAGE)
Modified: trunk/Source/WebCore/page/SettingsBase.h (256483 => 256484)
--- trunk/Source/WebCore/page/SettingsBase.h 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebCore/page/SettingsBase.h 2020-02-12 23:03:35 UTC (rev 256484)
@@ -194,6 +194,7 @@
void scrollingPerformanceLoggingEnabledChanged();
void hiddenPageDOMTimerThrottlingStateChanged();
void hiddenPageCSSAnimationSuspensionEnabledChanged();
+ void renderingUpdateThrottlingEnabledChanged();
void resourceUsageOverlayVisibleChanged();
void iceCandidateFilteringEnabledChanged();
#if ENABLE(TEXT_AUTOSIZING)
Modified: trunk/Source/WebKit/ChangeLog (256483 => 256484)
--- trunk/Source/WebKit/ChangeLog 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKit/ChangeLog 2020-02-12 23:03:35 UTC (rev 256484)
@@ -1,3 +1,16 @@
+2020-02-12 Truitt Savell <[email protected]>
+
+ Unreviewed, rolling out r256463.
+
+ Caused major flakiness on Mac wk2
+
+ Reverted changeset:
+
+ "REGRESSION (r255158): http/tests/frame-throttling/raf-
+ throttle-in-cross-origin-subframe.html is a flaky failure"
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+ https://trac.webkit.org/changeset/256463
+
2020-02-12 Simon Fraser <[email protected]>
Remove CSS_DEVICE_ADAPTATION
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (256483 => 256484)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-02-12 23:03:35 UTC (rev 256484)
@@ -496,6 +496,10 @@
type: bool
defaultValue: DEFAULT_HIDDEN_PAGE_CSS_ANIMATION_SUSPENSION_ENABLED
+RenderingUpdateThrottlingEnabled:
+ type: bool
+ defaultValue: true
+
LowPowerVideoAudioBufferSizeEnabled:
type: bool
defaultValue: true
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (256483 => 256484)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2020-02-12 23:03:35 UTC (rev 256484)
@@ -1319,6 +1319,16 @@
return toImpl(preferencesRef)->hiddenPageCSSAnimationSuspensionEnabled();
}
+void WKPreferencesSetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferencesRef, bool enabled)
+{
+ toImpl(preferencesRef)->setRenderingUpdateThrottlingEnabled(enabled);
+}
+
+bool WKPreferencesGetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->renderingUpdateThrottlingEnabled();
+}
+
void WKPreferencesSetIncrementalRenderingSuppressionTimeout(WKPreferencesRef preferencesRef, double timeout)
{
toImpl(preferencesRef)->setIncrementalRenderingSuppressionTimeout(timeout);
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h (256483 => 256484)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h 2020-02-12 23:03:35 UTC (rev 256484)
@@ -306,6 +306,10 @@
WK_EXPORT void WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled(WKPreferencesRef preferences, bool enabled);
WK_EXPORT bool WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled(WKPreferencesRef preferences);
+// Defaults to true.
+WK_EXPORT void WKPreferencesSetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferences, bool enabled);
+WK_EXPORT bool WKPreferencesGetRenderingUpdateThrottlingEnabled(WKPreferencesRef preferences);
+
// Defaults to false
WK_EXPORT void WKPreferencesSetSnapshotAllPlugIns(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetSnapshotAllPlugIns(WKPreferencesRef preferencesRef);
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (256483 => 256484)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-02-12 23:03:35 UTC (rev 256484)
@@ -1,3 +1,16 @@
+2020-02-12 Truitt Savell <[email protected]>
+
+ Unreviewed, rolling out r256463.
+
+ Caused major flakiness on Mac wk2
+
+ Reverted changeset:
+
+ "REGRESSION (r255158): http/tests/frame-throttling/raf-
+ throttle-in-cross-origin-subframe.html is a flaky failure"
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+ https://trac.webkit.org/changeset/256463
+
2020-02-12 Simon Fraser <[email protected]>
Remove CSS_DEVICE_ADAPTATION
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (256483 => 256484)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-02-12 23:03:35 UTC (rev 256484)
@@ -166,6 +166,7 @@
#define WebKitPlugInSnapshottingEnabledPreferenceKey @"WebKitPlugInSnapshottingEnabled"
#define WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey @"WebKitHiddenPageDOMTimerThrottlingEnabled"
#define WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey @"WebKitHiddenPageCSSAnimationSuspensionEnabled"
+#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey @"WebKitRenderingUpdateThrottlingEnabled"
#define WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey @"WebKitLowPowerVideoAudioBufferSizeEnabled"
#define WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey @"WebKitUseLegacyTextAlignPositionedElementBehavior"
#define WebKitMediaSourceEnabledPreferenceKey @"WebKitMediaSourceEnabled"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (256483 => 256484)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-02-12 23:03:35 UTC (rev 256484)
@@ -594,6 +594,7 @@
[NSNumber numberWithLongLong:ApplicationCacheStorage::noQuota()], WebKitApplicationCacheDefaultOriginQuota,
@NO, WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey,
@YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey,
+ @YES, WebKitRenderingUpdateThrottlingEnabledPreferenceKey,
@NO, WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey,
@NO, WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey,
@@ -2796,6 +2797,16 @@
[self _setBoolValue:enabled forKey:WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey];
}
+- (BOOL)renderingUpdateThrottlingEnabled
+{
+ return [self _boolValueForKey:WebKitRenderingUpdateThrottlingEnabledPreferenceKey];
+}
+
+- (void)setRenderingUpdateThrottlingEnabled:(BOOL)enabled
+{
+ [self _setBoolValue:enabled forKey:WebKitRenderingUpdateThrottlingEnabledPreferenceKey];
+}
+
- (BOOL)lowPowerVideoAudioBufferSizeEnabled
{
return [self _boolValueForKey:WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey];
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (256483 => 256484)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-02-12 23:03:35 UTC (rev 256484)
@@ -492,6 +492,9 @@
- (BOOL)hiddenPageCSSAnimationSuspensionEnabled;
- (void)setHiddenPageCSSAnimationSuspensionEnabled:(BOOL)flag;
+- (BOOL)renderingUpdateThrottlingEnabled;
+- (void)setRenderingUpdateThrottlingEnabled:(BOOL)flag;
+
- (BOOL)lowPowerVideoAudioBufferSizeEnabled;
- (void)setLowPowerVideoAudioBufferSizeEnabled:(BOOL)enabled;
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (256483 => 256484)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-02-12 23:03:35 UTC (rev 256484)
@@ -3129,6 +3129,7 @@
settings.setHiddenPageDOMTimerThrottlingEnabled([preferences hiddenPageDOMTimerThrottlingEnabled]);
settings.setHiddenPageCSSAnimationSuspensionEnabled([preferences hiddenPageCSSAnimationSuspensionEnabled]);
+ settings.setRenderingUpdateThrottlingEnabled([preferences renderingUpdateThrottlingEnabled]);
WebCore::DeprecatedGlobalSettings::setResourceLoadStatisticsEnabled([preferences resourceLoadStatisticsEnabled]);
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (256483 => 256484)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2020-02-12 23:03:35 UTC (rev 256484)
@@ -1,3 +1,16 @@
+2020-02-12 Truitt Savell <[email protected]>
+
+ Unreviewed, rolling out r256463.
+
+ Caused major flakiness on Mac wk2
+
+ Reverted changeset:
+
+ "REGRESSION (r255158): http/tests/frame-throttling/raf-
+ throttle-in-cross-origin-subframe.html is a flaky failure"
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+ https://trac.webkit.org/changeset/256463
+
2020-02-12 Said Abou-Hallawa <[email protected]>
REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
Modified: trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl (256483 => 256484)
--- trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl 2020-02-12 23:03:35 UTC (rev 256484)
@@ -258,6 +258,8 @@
HRESULT setAspectRatioOfImgFromWidthAndHeightEnabled([in] BOOL enabled);
HRESULT setWebSQLEnabled([in] BOOL enabled);
HRESULT webSQLEnabled([out, retval] BOOL* enabled);
+ HRESULT setRenderingUpdateThrottlingEnabled([in] BOOL enabled);
+ HRESULT renderingUpdateThrottlingEnabled([out, retval] BOOL* enabled);
}
[uuid(04D4AAE1-5D01-4CCD-B46E-C022F10A6826)]
Modified: trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h (256483 => 256484)
--- trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h 2020-02-12 23:03:35 UTC (rev 256484)
@@ -227,3 +227,7 @@
#define WebKitAspectRatioOfImgFromWidthAndHeightEnabledPreferenceKey "WebKitAspectRatioOfImgFromWidthAndHeightEnabled"
#define WebKitWebSQLEnabledPreferenceKey "WebKitWebSQLEnabled"
+
+#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey "WebKitRenderingUpdateThrottlingEnabled"
+
+#define WebKitRenderingUpdateThrottlingEnabledPreferenceKey "WebKitRenderingUpdateThrottlingEnabled"
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (256483 => 256484)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2020-02-12 23:03:35 UTC (rev 256484)
@@ -354,6 +354,8 @@
CFDictionaryAddValue(defaults, CFSTR(WebKitWebSQLEnabledPreferenceKey), kCFBooleanFalse);
+ CFDictionaryAddValue(defaults, CFSTR(WebKitRenderingUpdateThrottlingEnabledPreferenceKey), kCFBooleanTrue);
+
defaultSettings = defaults;
#endif
}
@@ -2470,6 +2472,20 @@
return S_OK;
}
+HRESULT WebPreferences::renderingUpdateThrottlingEnabled(_Out_ BOOL* enabled)
+{
+ if (!enabled)
+ return E_POINTER;
+ *enabled = boolValueForKey(WebKitRenderingUpdateThrottlingEnabledPreferenceKey);
+ return S_OK;
+}
+
+HRESULT WebPreferences::setRenderingUpdateThrottlingEnabled(BOOL enabled)
+{
+ setBoolValue(WebKitRenderingUpdateThrottlingEnabledPreferenceKey, enabled);
+ return S_OK;
+}
+
HRESULT WebPreferences::allowTopNavigationToDataURLs(_Out_ BOOL* allowAccess)
{
if (!allowAccess)
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.h (256483 => 256484)
--- trunk/Source/WebKitLegacy/win/WebPreferences.h 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.h 2020-02-12 23:03:35 UTC (rev 256484)
@@ -303,6 +303,8 @@
virtual HRESULT STDMETHODCALLTYPE setAspectRatioOfImgFromWidthAndHeightEnabled(BOOL);
virtual HRESULT STDMETHODCALLTYPE webSQLEnabled(_Out_ BOOL*);
virtual HRESULT STDMETHODCALLTYPE setWebSQLEnabled(BOOL);
+ virtual HRESULT STDMETHODCALLTYPE renderingUpdateThrottlingEnabled(_Out_ BOOL*);
+ virtual HRESULT STDMETHODCALLTYPE setRenderingUpdateThrottlingEnabled(BOOL);
// IWebPreferencesPrivate8
virtual HRESULT STDMETHODCALLTYPE allowTopNavigationToDataURLs(_Out_ BOOL*);
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (256483 => 256484)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2020-02-12 23:03:35 UTC (rev 256484)
@@ -5615,6 +5615,11 @@
return hr;
settings.setRequestAnimationFrameEnabled(enabled);
+ hr = prefsPrivate->renderingUpdateThrottlingEnabled(&enabled);
+ if (FAILED(hr))
+ return hr;
+ settings.setRenderingUpdateThrottlingEnabled(enabled);
+
hr = prefsPrivate->mockScrollbarsEnabled(&enabled);
if (FAILED(hr))
return hr;
Modified: trunk/Tools/ChangeLog (256483 => 256484)
--- trunk/Tools/ChangeLog 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Tools/ChangeLog 2020-02-12 23:03:35 UTC (rev 256484)
@@ -1,3 +1,16 @@
+2020-02-12 Truitt Savell <[email protected]>
+
+ Unreviewed, rolling out r256463.
+
+ Caused major flakiness on Mac wk2
+
+ Reverted changeset:
+
+ "REGRESSION (r255158): http/tests/frame-throttling/raf-
+ throttle-in-cross-origin-subframe.html is a flaky failure"
+ https://bugs.webkit.org/show_bug.cgi?id=206839
+ https://trac.webkit.org/changeset/256463
+
2020-02-12 Jonathan Bedard <[email protected]>
results.webkit.org: Remove debug JS logging
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (256483 => 256484)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2020-02-12 23:03:35 UTC (rev 256484)
@@ -995,6 +995,7 @@
[preferences setHiddenPageDOMTimerThrottlingEnabled:NO];
[preferences setHiddenPageCSSAnimationSuspensionEnabled:NO];
+ [preferences setRenderingUpdateThrottlingEnabled:NO];
[preferences setRemotePlaybackEnabled:YES];
[preferences setMediaDevicesEnabled:YES];
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (256483 => 256484)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2020-02-12 23:03:35 UTC (rev 256484)
@@ -801,6 +801,7 @@
prefsPrivate->setWebAnimationsMutableTimelinesEnabled(TRUE);
prefsPrivate->setServerTimingEnabled(TRUE);
prefsPrivate->setAspectRatioOfImgFromWidthAndHeightEnabled(TRUE);
+ prefsPrivate->setRenderingUpdateThrottlingEnabled(FALSE);
// FIXME: WebGL2
// FIXME: WebRTC
}
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (256483 => 256484)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-02-12 22:52:50 UTC (rev 256483)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-02-12 23:03:35 UTC (rev 256484)
@@ -908,6 +908,7 @@
WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled(preferences, false);
WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled(preferences, false);
+ WKPreferencesSetRenderingUpdateThrottlingEnabled(preferences, false);
WKPreferencesSetAcceleratedDrawingEnabled(preferences, m_shouldUseAcceleratedDrawing || options.useAcceleratedDrawing);
// FIXME: We should be testing the default.
