Title: [256496] trunk/Source/WebCore
- Revision
- 256496
- Author
- [email protected]
- Date
- 2020-02-12 18:13:12 -0800 (Wed, 12 Feb 2020)
Log Message
[WK2][Soup] Implement NetworkStorageSession::getAllCookies
https://bugs.webkit.org/show_bug.cgi?id=207449
Patch by Pavel Feldman <[email protected]> on 2020-02-12
Reviewed by Carlos Garcia Campos.
* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::getAllCookies):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (256495 => 256496)
--- trunk/Source/WebCore/ChangeLog 2020-02-13 01:38:20 UTC (rev 256495)
+++ trunk/Source/WebCore/ChangeLog 2020-02-13 02:13:12 UTC (rev 256496)
@@ -1,3 +1,13 @@
+2020-02-12 Pavel Feldman <[email protected]>
+
+ [WK2][Soup] Implement NetworkStorageSession::getAllCookies
+ https://bugs.webkit.org/show_bug.cgi?id=207449
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/network/soup/NetworkStorageSessionSoup.cpp:
+ (WebCore::NetworkStorageSession::getAllCookies):
+
2020-02-12 Yusuke Suzuki <[email protected]>
CSSValuePool's constant CSS values should not be allocated dynamically (and same for Vectors)
Modified: trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp (256495 => 256496)
--- trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2020-02-13 01:38:20 UTC (rev 256495)
+++ trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2020-02-13 02:13:12 UTC (rev 256496)
@@ -413,8 +413,13 @@
Vector<Cookie> NetworkStorageSession::getAllCookies()
{
- // FIXME: Implement for WK2 to use.
- return { };
+ Vector<Cookie> cookies;
+ GUniquePtr<GSList> cookiesList(soup_cookie_jar_all_cookies(cookieStorage()));
+ for (GSList* item = cookiesList.get(); item; item = g_slist_next(item)) {
+ GUniquePtr<SoupCookie> soupCookie(static_cast<SoupCookie*>(item->data));
+ cookies.append(WebCore::Cookie(soupCookie.get()));
+ }
+ return cookies;
}
Vector<Cookie> NetworkStorageSession::getCookies(const URL& url)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
