Diff
Modified: trunk/LayoutTests/ChangeLog (103750 => 103751)
--- trunk/LayoutTests/ChangeLog 2011-12-28 02:43:44 UTC (rev 103750)
+++ trunk/LayoutTests/ChangeLog 2011-12-28 02:47:37 UTC (rev 103751)
@@ -1,3 +1,13 @@
+2011-12-27 Dominic Cooney <[email protected]>
+
+ Remove initWebKitAnimationEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71698
+
+ Reviewed by Ojan Vafai.
+
+ * fast/events/init-events-expected.txt:
+ * fast/events/script-tests/init-events.js:
+
2011-12-27 Ryosuke Niwa <[email protected]>
Chromium rebaselines for http://crbug.com/9768. It's hard to make sense of these failures at this point
Modified: trunk/LayoutTests/fast/events/init-events-expected.txt (103750 => 103751)
--- trunk/LayoutTests/fast/events/init-events-expected.txt 2011-12-28 02:43:44 UTC (rev 103750)
+++ trunk/LayoutTests/fast/events/init-events-expected.txt 2011-12-28 02:47:37 UTC (rev 103751)
@@ -164,15 +164,6 @@
PASS testInitEvent('UI', '"a", false, false, window, 1001').pageX is 0
PASS testInitEvent('UI', '"a", false, false, window, 1001').pageY is 0
PASS testInitEvent('UI', '"a", false, false, window, 1001').which is 0
-PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').type is 'a'
-PASS testInitEvent('WebKitAnimation', 'null, false, false, "b", 1001').type is 'null'
-PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').bubbles is false
-PASS testInitEvent('WebKitAnimation', '"a", true, false, "b", 1001').bubbles is true
-PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').cancelable is false
-PASS testInitEvent('WebKitAnimation', '"a", false, true, "b", 1001').cancelable is true
-PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').animationName is 'b'
-PASS testInitEvent('WebKitAnimation', '"a", false, false, null, 1001').animationName is 'null'
-PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').elapsedTime is 1001
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/events/script-tests/init-events.js (103750 => 103751)
--- trunk/LayoutTests/fast/events/script-tests/init-events.js 2011-12-28 02:43:44 UTC (rev 103750)
+++ trunk/LayoutTests/fast/events/script-tests/init-events.js 2011-12-28 02:47:37 UTC (rev 103751)
@@ -181,14 +181,4 @@
shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').pageY", "0");
shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').which", "0");
-shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').type", "'a'");
-shouldBe("testInitEvent('WebKitAnimation', 'null, false, false, \"b\", 1001').type", "'null'");
-shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').bubbles", "false");
-shouldBe("testInitEvent('WebKitAnimation', '\"a\", true, false, \"b\", 1001').bubbles", "true");
-shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').cancelable", "false");
-shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, true, \"b\", 1001').cancelable", "true");
-shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').animationName", "'b'");
-shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, null, 1001').animationName", "'null'");
-shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').elapsedTime", "1001");
-
// WheelEvent has no init function yet; roughly speaking, we are waiting for that part of DOM 3 to stabilize.
Modified: trunk/Source/WebCore/ChangeLog (103750 => 103751)
--- trunk/Source/WebCore/ChangeLog 2011-12-28 02:43:44 UTC (rev 103750)
+++ trunk/Source/WebCore/ChangeLog 2011-12-28 02:47:37 UTC (rev 103751)
@@ -1,3 +1,19 @@
+2011-12-27 Dominic Cooney <[email protected]>
+
+ Remove initWebKitAnimationEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71698
+
+ Reviewed by Ojan Vafai.
+
+ Now that WebKitAnimationEvent has a constructor, we don't need
+ this
+ method. <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15338> is
+ tracking the change to the CSS Animations spec.
+
+ * dom/WebKitAnimationEvent.cpp:
+ * dom/WebKitAnimationEvent.h:
+ * dom/WebKitAnimationEvent.idl:
+
2011-12-27 Dominic Cooney <[email protected]>
Remove initWebKitTransitionEvent method
Modified: trunk/Source/WebCore/dom/WebKitAnimationEvent.cpp (103750 => 103751)
--- trunk/Source/WebCore/dom/WebKitAnimationEvent.cpp 2011-12-28 02:43:44 UTC (rev 103750)
+++ trunk/Source/WebCore/dom/WebKitAnimationEvent.cpp 2011-12-28 02:47:37 UTC (rev 103751)
@@ -59,21 +59,6 @@
{
}
-void WebKitAnimationEvent::initWebKitAnimationEvent(const AtomicString& type,
- bool canBubbleArg,
- bool cancelableArg,
- const String& animationName,
- double elapsedTime)
-{
- if (dispatched())
- return;
-
- initEvent(type, canBubbleArg, cancelableArg);
-
- m_animationName = animationName;
- m_elapsedTime = elapsedTime;
-}
-
const String& WebKitAnimationEvent::animationName() const
{
return m_animationName;
Modified: trunk/Source/WebCore/dom/WebKitAnimationEvent.h (103750 => 103751)
--- trunk/Source/WebCore/dom/WebKitAnimationEvent.h 2011-12-28 02:43:44 UTC (rev 103750)
+++ trunk/Source/WebCore/dom/WebKitAnimationEvent.h 2011-12-28 02:47:37 UTC (rev 103751)
@@ -54,12 +54,6 @@
virtual ~WebKitAnimationEvent();
- void initWebKitAnimationEvent(const AtomicString& type,
- bool canBubbleArg,
- bool cancelableArg,
- const String& animationName,
- double elapsedTime);
-
const String& animationName() const;
double elapsedTime() const;
Modified: trunk/Source/WebCore/dom/WebKitAnimationEvent.idl (103750 => 103751)
--- trunk/Source/WebCore/dom/WebKitAnimationEvent.idl 2011-12-28 02:43:44 UTC (rev 103750)
+++ trunk/Source/WebCore/dom/WebKitAnimationEvent.idl 2011-12-28 02:47:37 UTC (rev 103751)
@@ -30,12 +30,6 @@
] WebKitAnimationEvent : Event {
readonly attribute [InitializedByConstructor] DOMString animationName;
readonly attribute [InitializedByConstructor] double elapsedTime;
-
- void initWebKitAnimationEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
- in [Optional=CallWithDefaultValue] boolean canBubbleArg,
- in [Optional=CallWithDefaultValue] boolean cancelableArg,
- in [Optional=CallWithDefaultValue] DOMString animationNameArg,
- in [Optional=CallWithDefaultValue] double elapsedTimeArg);
};
}
