Title: [256537] trunk/LayoutTests
- Revision
- 256537
- Author
- [email protected]
- Date
- 2020-02-13 13:41:56 -0800 (Thu, 13 Feb 2020)
Log Message
REGRESSION: (256381) [ macOS ] http/tests/workers/service/serviceworkerclients-claim.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207653
<rdar://problem/59396225>
Reviewed by Chris Dumez.
console log message output was flaky.
Make sure to end the fetch and post a message so that the console log message will appear in the expected.txt reliably.
* http/tests/workers/service/serviceworkerclients-claim.https-expected.txt:
* http/tests/workers/service/serviceworkerclients-claim.https.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (256536 => 256537)
--- trunk/LayoutTests/ChangeLog 2020-02-13 21:40:08 UTC (rev 256536)
+++ trunk/LayoutTests/ChangeLog 2020-02-13 21:41:56 UTC (rev 256537)
@@ -1,3 +1,17 @@
+2020-02-13 Youenn Fablet <[email protected]>
+
+ REGRESSION: (256381) [ macOS ] http/tests/workers/service/serviceworkerclients-claim.https.html is flaky failing
+ https://bugs.webkit.org/show_bug.cgi?id=207653
+ <rdar://problem/59396225>
+
+ Reviewed by Chris Dumez.
+
+ console log message output was flaky.
+ Make sure to end the fetch and post a message so that the console log message will appear in the expected.txt reliably.
+
+ * http/tests/workers/service/serviceworkerclients-claim.https-expected.txt:
+ * http/tests/workers/service/serviceworkerclients-claim.https.html:
+
2020-02-13 Jason Lawrence <[email protected]>
[ Mac ] fast/images/webp-as-image.html is failing.
Modified: trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt (256536 => 256537)
--- trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt 2020-02-13 21:40:08 UTC (rev 256536)
+++ trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt 2020-02-13 21:41:56 UTC (rev 256537)
@@ -1,6 +1,5 @@
CONSOLE MESSAGE: Origin null is not allowed by Access-Control-Allow-Origin.
CONSOLE MESSAGE: Fetch API cannot load https://127.0.0.1:8443/pinkelephant due to access control checks.
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: TypeError: Origin null is not allowed by Access-Control-Allow-Origin.
PASS Setup worker
Modified: trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html (256536 => 256537)
--- trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html 2020-02-13 21:40:08 UTC (rev 256536)
+++ trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html 2020-02-13 21:41:56 UTC (rev 256537)
@@ -54,18 +54,17 @@
' var text = await response.text();' +
' window.parent.postMessage(text, "*");' +
'}' +
- 'doTest();' +
+ 'doTest().catch(e => {' +
+ ' window.parent.postMessage("Fetch failed", "*");'+
+ '});' +
'</scr' + 'ipt></h' + 'tml>';
promise_test(async (test) => {
- var promise = new Promise((resolve, reject) => {
- window.addEventListener("message", (event) => {
- reject("Received a message from iframe:" + event.data);
- }, false);
- setTimeout(resolve, 100);
+ var promise = new Promise((resolve) => {
+ window.addEventListener("message", (event) => resolve(event.data));
});
var frame = await withFrame("data:text/html," + htmlString);
- return promise;
+ assert_equals(await promise, "Fetch failed");
}, "Test data URL frame");
promise_test(async (test) => {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
