Title: [256569] trunk/Source/WebCore
Revision
256569
Author
[email protected]
Date
2020-02-13 15:53:37 -0800 (Thu, 13 Feb 2020)

Log Message

Add missing call to completionHandler
https://bugs.webkit.org/show_bug.cgi?id=207720
<rdar://problem/59436915>

Reviewed by Chris Dumez.

Bug 179641 (r225702) updated
SubresourceLoader::willSendRequestInternal with a return call without
first calling the completionHandler. Address this by adding the call
to the completionHandler.

No new tests -- it's not possible to control execution into the
affected code path.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (256568 => 256569)


--- trunk/Source/WebCore/ChangeLog	2020-02-13 23:51:25 UTC (rev 256568)
+++ trunk/Source/WebCore/ChangeLog	2020-02-13 23:53:37 UTC (rev 256569)
@@ -1,3 +1,22 @@
+2020-02-13  Keith Rollin  <[email protected]>
+
+        Add missing call to completionHandler
+        https://bugs.webkit.org/show_bug.cgi?id=207720
+        <rdar://problem/59436915>
+
+        Reviewed by Chris Dumez.
+
+        Bug 179641 (r225702) updated
+        SubresourceLoader::willSendRequestInternal with a return call without
+        first calling the completionHandler. Address this by adding the call
+        to the completionHandler.
+
+        No new tests -- it's not possible to control execution into the
+        affected code path.
+
+        * loader/SubresourceLoader.cpp:
+        (WebCore::SubresourceLoader::willSendRequestInternal):
+
 2020-02-13  Tim Horton  <[email protected]>
 
         iOS: Autoscrolling is too fast and way too aggressive

Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (256568 => 256569)


--- trunk/Source/WebCore/loader/SubresourceLoader.cpp	2020-02-13 23:51:25 UTC (rev 256568)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp	2020-02-13 23:53:37 UTC (rev 256569)
@@ -239,7 +239,7 @@
             m_resource->responseReceived(opaqueRedirectedResponse);
             if (reachedTerminalState()) {
                 RELEASE_LOG_IF_ALLOWED("willSendRequestinternal: reached terminal state (frame = %p, frameLoader = %p, resourceID = %lu)", frame(), frameLoader(), identifier());
-                return;
+                return completionHandler(WTFMove(newRequest));
             }
 
             RELEASE_LOG_IF_ALLOWED("willSendRequestinternal: resource load completed (frame = %p, frameLoader = %p, resourceID = %lu)", frame(), frameLoader(), identifier());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to