Title: [256571] trunk/Source
Revision
256571
Author
[email protected]
Date
2020-02-13 16:12:06 -0800 (Thu, 13 Feb 2020)

Log Message

REGRESSION (r255961): Default state for data URL handling is incorrect
https://bugs.webkit.org/show_bug.cgi?id=207719
<rdar://problem/59334011>

Reviewed by Chris Dumez.

The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
while we work through compatibility issues.

Source/WebCore:

Tested by existing test cases.

* page/Settings.yaml:

Source/WebKit:

* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (256570 => 256571)


--- trunk/Source/WebCore/ChangeLog	2020-02-14 00:00:09 UTC (rev 256570)
+++ trunk/Source/WebCore/ChangeLog	2020-02-14 00:12:06 UTC (rev 256571)
@@ -1,3 +1,18 @@
+2020-02-13  Brent Fulgham  <[email protected]>
+
+        REGRESSION (r255961): Default state for data URL handling is incorrect
+        https://bugs.webkit.org/show_bug.cgi?id=207719
+        <rdar://problem/59334011>
+
+        Reviewed by Chris Dumez.
+
+        The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
+        while we work through compatibility issues.
+
+        Tested by existing test cases.
+
+        * page/Settings.yaml:
+
 2020-02-13  Keith Rollin  <[email protected]>
 
         Add missing call to completionHandler

Modified: trunk/Source/WebCore/page/Settings.yaml (256570 => 256571)


--- trunk/Source/WebCore/page/Settings.yaml	2020-02-14 00:00:09 UTC (rev 256570)
+++ trunk/Source/WebCore/page/Settings.yaml	2020-02-14 00:12:06 UTC (rev 256571)
@@ -108,7 +108,7 @@
 allowCrossOriginSubresourcesToAskForCredentials:
   initial: false
 allowTopNavigationToDataURLs:
-  initial: false
+  initial: true
 needsStorageAccessFromFileURLsQuirk:
   initial: true
 needsFrameNameFallbackToIdQuirk:

Modified: trunk/Source/WebKit/ChangeLog (256570 => 256571)


--- trunk/Source/WebKit/ChangeLog	2020-02-14 00:00:09 UTC (rev 256570)
+++ trunk/Source/WebKit/ChangeLog	2020-02-14 00:12:06 UTC (rev 256571)
@@ -1,3 +1,17 @@
+2020-02-13  Brent Fulgham  <[email protected]>
+
+        REGRESSION (r255961): Default state for data URL handling is incorrect
+        https://bugs.webkit.org/show_bug.cgi?id=207719
+        <rdar://problem/59334011>
+
+        Reviewed by Chris Dumez.
+
+        The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
+        while we work through compatibility issues.
+
+        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+        (-[WKWebViewConfiguration init]):
+
 2020-02-13  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r254557.

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (256570 => 256571)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2020-02-14 00:00:09 UTC (rev 256570)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2020-02-14 00:12:06 UTC (rev 256571)
@@ -236,7 +236,7 @@
     _convertsPositionStyleOnCopy = NO;
     _allowsMetaRefresh = YES;
     _allowUniversalAccessFromFileURLs = NO;
-    _allowTopNavigationToDataURLs = NO;
+    _allowTopNavigationToDataURLs = YES;
     _needsStorageAccessFromFileURLsQuirk = YES;
 
 #if PLATFORM(IOS_FAMILY)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to