Title: [256576] branches/safari-610.1.3-branch/Source
Revision
256576
Author
[email protected]
Date
2020-02-13 17:17:27 -0800 (Thu, 13 Feb 2020)

Log Message

Cherry-pick r256571. rdar://problem/59443242

    REGRESSION (r255961): Default state for data URL handling is incorrect
    https://bugs.webkit.org/show_bug.cgi?id=207719
    <rdar://problem/59334011>

    Reviewed by Chris Dumez.

    The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
    while we work through compatibility issues.

    Source/WebCore:

    Tested by existing test cases.

    * page/Settings.yaml:

    Source/WebKit:

    * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
    (-[WKWebViewConfiguration init]):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610.1.3-branch/Source/WebCore/ChangeLog (256575 => 256576)


--- branches/safari-610.1.3-branch/Source/WebCore/ChangeLog	2020-02-14 01:13:36 UTC (rev 256575)
+++ branches/safari-610.1.3-branch/Source/WebCore/ChangeLog	2020-02-14 01:17:27 UTC (rev 256576)
@@ -1,3 +1,44 @@
+2020-02-13  Kocsen Chung  <[email protected]>
+
+        Cherry-pick r256571. rdar://problem/59443242
+
+    REGRESSION (r255961): Default state for data URL handling is incorrect
+    https://bugs.webkit.org/show_bug.cgi?id=207719
+    <rdar://problem/59334011>
+    
+    Reviewed by Chris Dumez.
+    
+    The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
+    while we work through compatibility issues.
+    
+    Source/WebCore:
+    
+    Tested by existing test cases.
+    
+    * page/Settings.yaml:
+    
+    Source/WebKit:
+    
+    * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+    (-[WKWebViewConfiguration init]):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-02-13  Brent Fulgham  <[email protected]>
+
+            REGRESSION (r255961): Default state for data URL handling is incorrect
+            https://bugs.webkit.org/show_bug.cgi?id=207719
+            <rdar://problem/59334011>
+
+            Reviewed by Chris Dumez.
+
+            The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
+            while we work through compatibility issues.
+
+            Tested by existing test cases.
+
+            * page/Settings.yaml:
+
 2020-02-13  Alan Coon  <[email protected]>
 
         Cherry-pick r256493. rdar://problem/59412867

Modified: branches/safari-610.1.3-branch/Source/WebCore/page/Settings.yaml (256575 => 256576)


--- branches/safari-610.1.3-branch/Source/WebCore/page/Settings.yaml	2020-02-14 01:13:36 UTC (rev 256575)
+++ branches/safari-610.1.3-branch/Source/WebCore/page/Settings.yaml	2020-02-14 01:17:27 UTC (rev 256576)
@@ -108,7 +108,7 @@
 allowCrossOriginSubresourcesToAskForCredentials:
   initial: false
 allowTopNavigationToDataURLs:
-  initial: false
+  initial: true
 needsStorageAccessFromFileURLsQuirk:
   initial: true
 needsFrameNameFallbackToIdQuirk:

Modified: branches/safari-610.1.3-branch/Source/WebKit/ChangeLog (256575 => 256576)


--- branches/safari-610.1.3-branch/Source/WebKit/ChangeLog	2020-02-14 01:13:36 UTC (rev 256575)
+++ branches/safari-610.1.3-branch/Source/WebKit/ChangeLog	2020-02-14 01:17:27 UTC (rev 256576)
@@ -1,3 +1,43 @@
+2020-02-13  Kocsen Chung  <[email protected]>
+
+        Cherry-pick r256571. rdar://problem/59443242
+
+    REGRESSION (r255961): Default state for data URL handling is incorrect
+    https://bugs.webkit.org/show_bug.cgi?id=207719
+    <rdar://problem/59334011>
+    
+    Reviewed by Chris Dumez.
+    
+    The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
+    while we work through compatibility issues.
+    
+    Source/WebCore:
+    
+    Tested by existing test cases.
+    
+    * page/Settings.yaml:
+    
+    Source/WebKit:
+    
+    * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+    (-[WKWebViewConfiguration init]):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-02-13  Brent Fulgham  <[email protected]>
+
+            REGRESSION (r255961): Default state for data URL handling is incorrect
+            https://bugs.webkit.org/show_bug.cgi?id=207719
+            <rdar://problem/59334011>
+
+            Reviewed by Chris Dumez.
+
+            The default selected in r255961 breaks too many WebKit framework users. Switch from opt-out to opt-in
+            while we work through compatibility issues.
+
+            * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+            (-[WKWebViewConfiguration init]):
+
 2020-02-13  Alan Coon  <[email protected]>
 
         Cherry-pick r256493. rdar://problem/59412867

Modified: branches/safari-610.1.3-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (256575 => 256576)


--- branches/safari-610.1.3-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2020-02-14 01:13:36 UTC (rev 256575)
+++ branches/safari-610.1.3-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2020-02-14 01:17:27 UTC (rev 256576)
@@ -236,7 +236,7 @@
     _convertsPositionStyleOnCopy = NO;
     _allowsMetaRefresh = YES;
     _allowUniversalAccessFromFileURLs = NO;
-    _allowTopNavigationToDataURLs = NO;
+    _allowTopNavigationToDataURLs = YES;
     _needsStorageAccessFromFileURLsQuirk = YES;
 
 #if PLATFORM(IOS_FAMILY)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to