Title: [256596] releases/WebKitGTK/webkit-2.26
- Revision
- 256596
- Author
- [email protected]
- Date
- 2020-02-14 01:40:30 -0800 (Fri, 14 Feb 2020)
Log Message
Merge r254301 - REGRESSION (r253662): Large Data URLs are not being handled properly
https://bugs.webkit.org/show_bug.cgi?id=205979
<rdar://problem/58346124>
Reviewed by Youenn Fablet.
Source/WebCore:
The URL size limitation added in r253662 was too low. We should bump it to handle
reasonable data URI sizes.
Test: fast/url/data-url-large.html.
* page/SecurityOrigin.cpp:
LayoutTests:
* fast/url/data-url-large-expected.txt: Added.
* fast/url/data-url-large.html: Added.
Modified Paths
Added Paths
Diff
Modified: releases/WebKitGTK/webkit-2.26/LayoutTests/ChangeLog (256595 => 256596)
--- releases/WebKitGTK/webkit-2.26/LayoutTests/ChangeLog 2020-02-14 09:40:25 UTC (rev 256595)
+++ releases/WebKitGTK/webkit-2.26/LayoutTests/ChangeLog 2020-02-14 09:40:30 UTC (rev 256596)
@@ -1,3 +1,14 @@
+2020-01-09 Brent Fulgham <[email protected]>
+
+ REGRESSION (r253662): Large Data URLs are not being handled properly
+ https://bugs.webkit.org/show_bug.cgi?id=205979
+ <rdar://problem/58346124>
+
+ Reviewed by Youenn Fablet.
+
+ * fast/url/data-url-large-expected.txt: Added.
+ * fast/url/data-url-large.html: Added.
+
2020-01-08 Myles C. Maxfield <[email protected]>
Fix specification violation in Font Loading API
Added: releases/WebKitGTK/webkit-2.26/LayoutTests/fast/url/data-url-large-expected.txt (0 => 256596)
--- releases/WebKitGTK/webkit-2.26/LayoutTests/fast/url/data-url-large-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.26/LayoutTests/fast/url/data-url-large-expected.txt 2020-02-14 09:40:30 UTC (rev 256596)
@@ -0,0 +1,5 @@
+PASS Large URL handled properly.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: releases/WebKitGTK/webkit-2.26/LayoutTests/fast/url/data-url-large.html (0 => 256596)
--- releases/WebKitGTK/webkit-2.26/LayoutTests/fast/url/data-url-large.html (rev 0)
+++ releases/WebKitGTK/webkit-2.26/LayoutTests/fast/url/data-url-large.html 2020-02-14 09:40:30 UTC (rev 256596)
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+jsTestIsAsync = true;
+const url = "" + "q".repeat(32535);
+
+const xhr = new XMLHttpRequest();
+xhr._onload_ = function() {
+ testPassed("Large URL handled properly.");
+ finishJSTest();
+}
+xhr._onerror_ = function() {
+ testFailed("Large URL was improperly rejected.");
+ finishJSTest();
+}
+xhr.open("GET", url);
+xhr.send();
+</script>
+</body>
+</html>
Modified: releases/WebKitGTK/webkit-2.26/Source/WebCore/ChangeLog (256595 => 256596)
--- releases/WebKitGTK/webkit-2.26/Source/WebCore/ChangeLog 2020-02-14 09:40:25 UTC (rev 256595)
+++ releases/WebKitGTK/webkit-2.26/Source/WebCore/ChangeLog 2020-02-14 09:40:30 UTC (rev 256596)
@@ -1,3 +1,18 @@
+2020-01-09 Brent Fulgham <[email protected]>
+
+ REGRESSION (r253662): Large Data URLs are not being handled properly
+ https://bugs.webkit.org/show_bug.cgi?id=205979
+ <rdar://problem/58346124>
+
+ Reviewed by Youenn Fablet.
+
+ The URL size limitation added in r253662 was too low. We should bump it to handle
+ reasonable data URI sizes.
+
+ Test: fast/url/data-url-large.html.
+
+ * page/SecurityOrigin.cpp:
+
2019-12-17 Brent Fulgham <[email protected]>
Limit URL to reasonable size
Modified: releases/WebKitGTK/webkit-2.26/Source/WebCore/page/SecurityOrigin.cpp (256595 => 256596)
--- releases/WebKitGTK/webkit-2.26/Source/WebCore/page/SecurityOrigin.cpp 2020-02-14 09:40:25 UTC (rev 256595)
+++ releases/WebKitGTK/webkit-2.26/Source/WebCore/page/SecurityOrigin.cpp 2020-02-14 09:40:30 UTC (rev 256596)
@@ -45,7 +45,7 @@
namespace WebCore {
-constexpr unsigned maximumURLSize = 0x8000;
+constexpr unsigned maximumURLSize = 0x04000000;
static bool schemeRequiresHost(const URL& url)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes