Title: [103769] trunk
- Revision
- 103769
- Author
- [email protected]
- Date
- 2011-12-28 10:08:37 -0800 (Wed, 28 Dec 2011)
Log Message
[V8][Chromium] 'randomString' in document.body.style always returns true
https://bugs.webkit.org/show_bug.cgi?id=75313
Reviewed by Adam Barth.
Source/WebCore:
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyQuery):
LayoutTests:
* fast/css/style-enumerate-properties-expected.txt:
* fast/css/style-enumerate-properties.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (103768 => 103769)
--- trunk/LayoutTests/ChangeLog 2011-12-28 16:06:48 UTC (rev 103768)
+++ trunk/LayoutTests/ChangeLog 2011-12-28 18:08:37 UTC (rev 103769)
@@ -1,5 +1,15 @@
2011-12-28 Alexander Pavlov <[email protected]>
+ [V8][Chromium] 'randomString' in document.body.style always returns true
+ https://bugs.webkit.org/show_bug.cgi?id=75313
+
+ Reviewed by Adam Barth.
+
+ * fast/css/style-enumerate-properties-expected.txt:
+ * fast/css/style-enumerate-properties.html:
+
+2011-12-28 Alexander Pavlov <[email protected]>
+
Web Inspector: Introduce a Profiler launcher view similar to that in the Audits panel
https://bugs.webkit.org/show_bug.cgi?id=75228
Modified: trunk/LayoutTests/fast/css/style-enumerate-properties-expected.txt (103768 => 103769)
--- trunk/LayoutTests/fast/css/style-enumerate-properties-expected.txt 2011-12-28 16:06:48 UTC (rev 103768)
+++ trunk/LayoutTests/fast/css/style-enumerate-properties-expected.txt 2011-12-28 18:08:37 UTC (rev 103769)
@@ -6,6 +6,9 @@
PASS 'borderTopColor' in document.body.style is true
PASS 'border' in document.body.style is true
PASS 'font' in document.body.style is true
+PASS 'webkitTransform' in document.body.style is true
+PASS 'WebkitTransform' in document.body.style is true
+PASS 'bogus-random-String' in document.body.style is false
PASS 'cssText' in document.body.style is true
PASS 'getPropertyCSSValue' in document.body.style is true
PASS The CSS property order is correct
Modified: trunk/LayoutTests/fast/css/style-enumerate-properties.html (103768 => 103769)
--- trunk/LayoutTests/fast/css/style-enumerate-properties.html 2011-12-28 16:06:48 UTC (rev 103768)
+++ trunk/LayoutTests/fast/css/style-enumerate-properties.html 2011-12-28 18:08:37 UTC (rev 103769)
@@ -18,6 +18,9 @@
shouldBeTrue("'borderTopColor' in document.body.style");
shouldBeTrue("'border' in document.body.style");
shouldBeTrue("'font' in document.body.style");
+ shouldBeTrue("'webkitTransform' in document.body.style");
+ shouldBeTrue("'WebkitTransform' in document.body.style");
+ shouldBeFalse("'bogus-random-String' in document.body.style");
shouldBeTrue("'cssText' in document.body.style");
shouldBeTrue("'getPropertyCSSValue' in document.body.style");
Modified: trunk/Source/WebCore/ChangeLog (103768 => 103769)
--- trunk/Source/WebCore/ChangeLog 2011-12-28 16:06:48 UTC (rev 103768)
+++ trunk/Source/WebCore/ChangeLog 2011-12-28 18:08:37 UTC (rev 103769)
@@ -1,3 +1,13 @@
+2011-12-28 Alexander Pavlov <[email protected]>
+
+ [V8][Chromium] 'randomString' in document.body.style always returns true
+ https://bugs.webkit.org/show_bug.cgi?id=75313
+
+ Reviewed by Adam Barth.
+
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+ (WebCore::V8CSSStyleDeclaration::namedPropertyQuery):
+
2011-12-28 Vsevolod Vlasov <[email protected]>
Web Inspector: Add domain.png to WebCore.gypi / WebKit.qrc.
Modified: trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp (103768 => 103769)
--- trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp 2011-12-28 16:06:48 UTC (rev 103768)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp 2011-12-28 18:08:37 UTC (rev 103769)
@@ -180,7 +180,11 @@
v8::Handle<v8::Integer> V8CSSStyleDeclaration::namedPropertyQuery(v8::Local<v8::String> v8Name, const v8::AccessorInfo& info)
{
INC_STATS("DOM.CSSStyleDeclaration.NamedPropertyQuery");
- return v8::Integer::New(v8::None);
+
+ if (cssPropertyInfo(v8Name))
+ return v8::Integer::New(v8::None);
+
+ return v8::Handle<v8::Integer>();
}
v8::Handle<v8::Value> V8CSSStyleDeclaration::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
