Title: [256668] branches/safari-609-branch/Source/WebKit
- Revision
- 256668
- Author
- repst...@apple.com
- Date
- 2020-02-14 19:01:25 -0800 (Fri, 14 Feb 2020)
Log Message
Cherry-pick r256233. rdar://problem/59447027
WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
<https://webkit.org/b/207519>
<rdar://problem/59043436>
Reviewed by Brent Fulgham.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::initializeClassesForParameterCoding):
- Change `className` to keep a copy of the CString object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (256667 => 256668)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-15 03:01:22 UTC (rev 256667)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-15 03:01:25 UTC (rev 256668)
@@ -1,5 +1,33 @@
2020-02-14 Russell Epstein <repst...@apple.com>
+ Cherry-pick r256233. rdar://problem/59447027
+
+ WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
+ <https://webkit.org/b/207519>
+ <rdar://problem/59043436>
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::initializeClassesForParameterCoding):
+ - Change `className` to keep a copy of the CString object.
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-02-10 David Kilzer <ddkil...@apple.com>
+
+ WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
+ <https://webkit.org/b/207519>
+ <rdar://problem/59043436>
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::initializeClassesForParameterCoding):
+ - Change `className` to keep a copy of the CString object.
+
+2020-02-14 Russell Epstein <repst...@apple.com>
+
Cherry-pick r256187. rdar://problem/59446994
Crash under WebProcessProxy::shouldSendPendingMessage()
Modified: branches/safari-609-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (256667 => 256668)
--- branches/safari-609-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-02-15 03:01:22 UTC (rev 256667)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-02-15 03:01:25 UTC (rev 256668)
@@ -691,10 +691,10 @@
auto mutableSet = adoptNS([standardClasses mutableCopy]);
for (const auto& customClass : customClasses) {
- const auto* className = customClass.utf8().data();
- Class objectClass = objc_lookUpClass(className);
+ auto className = customClass.utf8();
+ Class objectClass = objc_lookUpClass(className.data());
if (!objectClass) {
- WTFLogAlways("InjectedBundle::extendClassesForParameterCoder - Class %s is not a valid Objective C class.\n", className);
+ WTFLogAlways("InjectedBundle::extendClassesForParameterCoder - Class %s is not a valid Objective C class.\n", className.data());
break;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
