Title: [256717] trunk/LayoutTests
Revision
256717
Author
[email protected]
Date
2020-02-16 17:54:27 -0800 (Sun, 16 Feb 2020)

Log Message

[ Mac wk2 ] fast/events/keydown-1.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=154297
https://bugs.webkit.org/show_bug.cgi?id=207785
<rdar://problem/59469424>

Reviewed by Wenson Hsieh.

* fast/events/keydown-1.html: Attempt to deflake by using onload instead of a 200 ms timer.

* platform/mac-wk1/TestExpectations: Removed flaky expectation.

* platform/mac-wk2/TestExpectations: Removed flaky expectation. Also corrected a 
conflict that was landed in r256656 today.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (256716 => 256717)


--- trunk/LayoutTests/ChangeLog	2020-02-17 01:41:27 UTC (rev 256716)
+++ trunk/LayoutTests/ChangeLog	2020-02-17 01:54:27 UTC (rev 256717)
@@ -1,3 +1,19 @@
+2020-02-14  Alexey Proskuryakov  <[email protected]>
+
+        [ Mac wk2 ] fast/events/keydown-1.html is flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=154297
+        https://bugs.webkit.org/show_bug.cgi?id=207785
+        <rdar://problem/59469424>
+
+        Reviewed by Wenson Hsieh.
+
+        * fast/events/keydown-1.html: Attempt to deflake by using onload instead of a 200 ms timer.
+
+        * platform/mac-wk1/TestExpectations: Removed flaky expectation.
+
+        * platform/mac-wk2/TestExpectations: Removed flaky expectation. Also corrected a 
+        conflict that was landed in r256656 today.
+
 2020-02-16  Alexey Shvayka  <[email protected]>
 
         Implement EventTarget constructor

Modified: trunk/LayoutTests/fast/events/keydown-1.html (256716 => 256717)


--- trunk/LayoutTests/fast/events/keydown-1.html	2020-02-17 01:41:27 UTC (rev 256716)
+++ trunk/LayoutTests/fast/events/keydown-1.html	2020-02-17 01:54:27 UTC (rev 256717)
@@ -4,6 +4,11 @@
 <ul id="console"></ul>
 
 <script>
+if (window.testRunner) {
+    testRunner.dumpAsText();
+    testRunner.waitUntilDone();
+}
+
 function log(str) {
     var console = document.getElementById("console");
     var li = document.createElement("li");
@@ -25,7 +30,8 @@
 false);
 }
 
-function step2() {
+window._onload_ = function()
+{
     addEventListeners();
     
     if (!window.testRunner)
@@ -46,17 +52,7 @@
     eventSender.keyDown("delete");
 
     log(window.frames[0].document.body.innerText);
-    window.testRunner.notifyDone();
+    testRunner.notifyDone();
 }
-
-function runTest() {
-    if (window.testRunner) {
-        testRunner.dumpAsText();
-        window.testRunner.waitUntilDone();
-    }
-    window.setTimeout(step2, 200);
-}
-
-runTest();
 </script>
 </body>

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256716 => 256717)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-17 01:41:27 UTC (rev 256716)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-17 01:54:27 UTC (rev 256717)
@@ -205,8 +205,6 @@
 
 webkit.org/b/152789 webarchive/adopt-attribute-styled-body-webarchive.html [ Pass Crash ]
 
-webkit.org/b/154297 [ Debug ] fast/events/keydown-1.html [ Pass Failure ]
-
 webkit.org/b/155196 security/contentSecurityPolicy/video-with-blob-url-allowed-by-media-src-star.html [ Skip ]
 
 webkit.org/b/155067 storage/indexeddb/transaction-abort-private.html [ Pass Crash ]

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256716 => 256717)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-17 01:41:27 UTC (rev 256716)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-17 01:54:27 UTC (rev 256717)
@@ -1038,10 +1038,6 @@
 
 webkit.org/b/207779 webgpu/whlsl/dereference-pointer-should-type-check.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/207785 fast/events/keydown-1.html [ Pass Failure ]
-
-webkit.org/b/207793 fast/html/marquee-child-wrap.html [ Pass ImageOnlyFailure ]
-
 webkit.org/b/207796 [ Release ] fast/box-shadow/hidpi-box-shadow.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/207798 webrtc/connection-state.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to