Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (256728 => 256729)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2020-02-17 12:07:08 UTC (rev 256728)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2020-02-17 15:09:42 UTC (rev 256729)
@@ -158,6 +158,7 @@
self.addStep(CompileWebKit(skipUpload=True))
self.addStep(ValidatePatch(verifyBugClosed=False, addURLs=False))
self.addStep(RunWebKit1Tests())
+ self.addStep(SetBuildSummary())
class WinCairoFactory(Factory):
@@ -185,6 +186,7 @@
self.addStep(ValidatePatch(verifyBugClosed=False, addURLs=False))
if self.LayoutTestClass:
self.addStep(self.LayoutTestClass())
+ self.addStep(SetBuildSummary())
if self.APITestClass:
self.addStep(self.APITestClass())
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py (256728 => 256729)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py 2020-02-17 12:07:08 UTC (rev 256728)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py 2020-02-17 15:09:42 UTC (rev 256729)
@@ -154,3 +154,21 @@
_BuildStepFactory(steps.RunResultsdbpyTests),
_BuildStepFactory(steps.RunBuildWebKitOrgUnitTests),
])
+
+
+class TestBuildAndTestsFactory(TestCase):
+ def test_windows_factory(self):
+ factory = factories.WindowsFactory(platform='win', configuration='release', architectures=["x86_64"])
+ self.assertBuildSteps(factory.steps, [
+ _BuildStepFactory(steps.ConfigureBuild, platform='win', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+ _BuildStepFactory(steps.ValidatePatch, verifycqplus=False),
+ _BuildStepFactory(steps.PrintConfiguration),
+ _BuildStepFactory(steps.CheckOutSource),
+ _BuildStepFactory(steps.CheckOutSpecificRevision),
+ _BuildStepFactory(steps.ApplyPatch),
+ _BuildStepFactory(steps.KillOldProcesses),
+ _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
+ _BuildStepFactory(steps.ValidatePatch, verifyBugClosed=False, addURLs=False),
+ _BuildStepFactory(steps.RunWebKit1Tests),
+ _BuildStepFactory(steps.SetBuildSummary),
+ ])
Modified: trunk/Tools/ChangeLog (256728 => 256729)
--- trunk/Tools/ChangeLog 2020-02-17 12:07:08 UTC (rev 256728)
+++ trunk/Tools/ChangeLog 2020-02-17 15:09:42 UTC (rev 256729)
@@ -1,3 +1,16 @@
+2020-02-17 Aakash Jain <[email protected]>
+
+ [ews] add SetBuildSummary step for Windows EWS
+ https://bugs.webkit.org/show_bug.cgi?id=207556
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/factories.py:
+ (WindowsFactory.__init__):
+ (GTKBuildAndTestFactory.__init__):
+ * BuildSlaveSupport/ews-build/factories_unittest.py:
+ (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
+
2020-02-17 Alberto Garcia <[email protected]>
[WPE] Change the QML plugin install path
