Title: [257155] trunk/Source/WebKit
- Revision
- 257155
- Author
- [email protected]
- Date
- 2020-02-21 12:23:43 -0800 (Fri, 21 Feb 2020)
Log Message
Address post-review feedback in webkit.org/b/207352
https://bugs.webkit.org/show_bug.cgi?id=207352
Reviewed by Brian Weinstein.
Use m_mainFrame instead of going through Page, and also append the string "\n\n" instead of appending the
newline character twice.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getContentsAsString):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (257154 => 257155)
--- trunk/Source/WebKit/ChangeLog 2020-02-21 19:58:54 UTC (rev 257154)
+++ trunk/Source/WebKit/ChangeLog 2020-02-21 20:23:43 UTC (rev 257155)
@@ -1,3 +1,16 @@
+2020-02-21 Wenson Hsieh <[email protected]>
+
+ Address post-review feedback in webkit.org/b/207352
+ https://bugs.webkit.org/show_bug.cgi?id=207352
+
+ Reviewed by Brian Weinstein.
+
+ Use m_mainFrame instead of going through Page, and also append the string "\n\n" instead of appending the
+ newline character twice.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::getContentsAsString):
+
2020-02-21 Peng Liu <[email protected]>
[Media in GPU process] Synchronize the properties of video layers in the GPU process with the hosting layer in the web process
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (257154 => 257155)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2020-02-21 19:58:54 UTC (rev 257154)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2020-02-21 20:23:43 UTC (rev 257155)
@@ -3446,12 +3446,10 @@
}
case ContentAsStringIncludesChildFrames::Yes: {
StringBuilder builder;
- for (RefPtr<Frame> frame = &corePage()->mainFrame(); frame; frame = frame->tree().traverseNextRendered()) {
+ for (RefPtr<Frame> frame = m_mainFrame->coreFrame(); frame; frame = frame->tree().traverseNextRendered()) {
if (auto* webFrame = WebFrame::fromCoreFrame(*frame)) {
- if (!builder.isEmpty()) {
- builder.append('\n');
- builder.append('\n');
- }
+ if (!builder.isEmpty())
+ builder.appendLiteral("\n\n");
builder.append(webFrame->contentsAsString());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
