Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (257400 => 257401)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-02-26 01:39:08 UTC (rev 257400)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-02-26 01:40:20 UTC (rev 257401)
@@ -1,3 +1,24 @@
+2020-02-25 Devin Rousso <[email protected]>
+
+ Web Inspector: move code for debug outlined focus element to the Debug folder so it isn't shipped
+ https://bugs.webkit.org/show_bug.cgi?id=208217
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Base/Main.js:
+ (WI.contentLoaded):
+ (WI.contentLoaded.setFocusDebugOutline): Deleted.
+ * UserInterface/Views/Main.css:
+ (body.focus-debug *:focus): Deleted.
+
+ * UserInterface/Debug/Bootstrap.js:
+ (WI.runBootstrapOperations):
+ (WI.runBootstrapOperations.setFocusDebugOutline): Added.
+ * UserInterface/Debug/Bootstrap.css: Added.
+ (body.focus-debug *:focus):
+
+ * UserInterface/Main.html:
+
2020-02-25 Nikita Vasilyev <[email protected]>
Web Inspector: VoiceOver should read "Console prompt" when focusing on it
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (257400 => 257401)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-02-26 01:39:08 UTC (rev 257400)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-02-26 01:40:20 UTC (rev 257401)
@@ -564,12 +564,6 @@
WI.diagnosticController.addRecorder(new WI.TabActivityDiagnosticEventRecorder(WI.diagnosticController));
WI.diagnosticController.addRecorder(new WI.TabNavigationDiagnosticEventRecorder(WI.diagnosticController));
}
-
- function setFocusDebugOutline() {
- document.body.classList.toggle("focus-debug", WI.settings.debugOutlineFocusedElement.value);
- }
- WI.settings.debugOutlineFocusedElement.addEventListener(WI.Setting.Event.Changed, setFocusDebugOutline);
- setFocusDebugOutline();
};
WI.performOneTimeFrontendInitializationsUsingTarget = function(target)
Added: trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css (0 => 257401)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css 2020-02-26 01:40:20 UTC (rev 257401)
@@ -0,0 +1,29 @@
+/*
+ * Copyright (C) 2020 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+body.focus-debug *:focus {
+ outline: 2px solid fuchsia !important;
+ outline-offset: -1px !important;
+}
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js (257400 => 257401)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js 2020-02-26 01:39:08 UTC (rev 257400)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js 2020-02-26 01:40:20 UTC (rev 257401)
@@ -124,6 +124,14 @@
InspectorFrontendHost.inspectInspector();
});
+ function setFocusDebugOutline() {
+ document.body.classList.toggle("focus-debug", WI.settings.debugOutlineFocusedElement.value);
+ }
+
+ WI.settings.debugOutlineFocusedElement.addEventListener(WI.Setting.Event.Changed, setFocusDebugOutline);
+
+ setFocusDebugOutline();
+
function updateDebugUI() {
dumpMessagesToolbarItem.hidden = !WI.showDebugUISetting.value;
inspectInspectorToolbarItem.hidden = !WI.showDebugUISetting.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Main.html (257400 => 257401)
--- trunk/Source/WebInspectorUI/UserInterface/Main.html 2020-02-26 01:39:08 UTC (rev 257400)
+++ trunk/Source/WebInspectorUI/UserInterface/Main.html 2020-02-26 01:40:20 UTC (rev 257401)
@@ -252,6 +252,7 @@
<link rel="stylesheet" href=""
<link rel="stylesheet" href=""
+ <link rel="stylesheet" href=""
<link rel="stylesheet" href=""
<link rel="stylesheet" href=""
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Main.css (257400 => 257401)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2020-02-26 01:39:08 UTC (rev 257400)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2020-02-26 01:40:20 UTC (rev 257401)
@@ -121,11 +121,6 @@
cursor: default;
}
-body.focus-debug *:focus {
- outline: 2px solid fuchsia !important;
- outline-offset: -1px !important;
-}
-
input[type=range] {
-webkit-appearance: none;
}
