Title: [257413] trunk/Source/WebKit
- Revision
- 257413
- Author
- [email protected]
- Date
- 2020-02-26 00:38:21 -0800 (Wed, 26 Feb 2020)
Log Message
Call pending m_unregisterJobs completion handlers when WebSWServerConnection goes away
https://bugs.webkit.org/show_bug.cgi?id=208208
<rdar://problem/59747016>
Reviewed by Alex Christensen.
Covered by existing tests in debug.
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::~WebSWServerConnection):
Make sure to call pending completion handlers at destruction time.
They will do nothing since their goal is to send back an IPC message
on a dead IPC connection.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (257412 => 257413)
--- trunk/Source/WebKit/ChangeLog 2020-02-26 07:49:06 UTC (rev 257412)
+++ trunk/Source/WebKit/ChangeLog 2020-02-26 08:38:21 UTC (rev 257413)
@@ -1,3 +1,19 @@
+2020-02-26 Youenn Fablet <[email protected]>
+
+ Call pending m_unregisterJobs completion handlers when WebSWServerConnection goes away
+ https://bugs.webkit.org/show_bug.cgi?id=208208
+ <rdar://problem/59747016>
+
+ Reviewed by Alex Christensen.
+
+ Covered by existing tests in debug.
+
+ * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+ (WebKit::WebSWServerConnection::~WebSWServerConnection):
+ Make sure to call pending completion handlers at destruction time.
+ They will do nothing since their goal is to send back an IPC message
+ on a dead IPC connection.
+
2020-02-25 Devin Rousso <[email protected]>
Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (257412 => 257413)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-26 07:49:06 UTC (rev 257412)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-26 08:38:21 UTC (rev 257413)
@@ -77,6 +77,8 @@
m_networkProcess->unregisterSWServerConnection(*this);
for (const auto& keyValue : m_clientOrigins)
server().unregisterServiceWorkerClient(keyValue.value, keyValue.key);
+ for (auto& completionHandler : m_unregisterJobs.values())
+ completionHandler(false);
}
void WebSWServerConnection::rejectJobInClient(ServiceWorkerJobIdentifier jobIdentifier, const ExceptionData& exceptionData)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
