Title: [257420] releases/WebKitGTK/webkit-2.28/Source/WebCore
- Revision
- 257420
- Author
- [email protected]
- Date
- 2020-02-26 02:54:57 -0800 (Wed, 26 Feb 2020)
Log Message
Merge r256636 - [Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
https://bugs.webkit.org/show_bug.cgi?id=207784
<rdar://problem/59251858>
Patch by Antoine Quint <[email protected]> on 2020-02-14
Reviewed by Dean Jackson.
After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
call should the Web Animations flag be on.
* page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog (257419 => 257420)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-02-26 10:54:52 UTC (rev 257419)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-02-26 10:54:57 UTC (rev 257420)
@@ -1,5 +1,19 @@
2020-02-14 Antoine Quint <[email protected]>
+ [Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
+ https://bugs.webkit.org/show_bug.cgi?id=207784
+ <rdar://problem/59251858>
+
+ Reviewed by Dean Jackson.
+
+ After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
+ call should the Web Animations flag be on.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
+
+2020-02-14 Antoine Quint <[email protected]>
+
[Web Animations] Style changes due to Web Animations should not trigger CSS Transitions
https://bugs.webkit.org/show_bug.cgi?id=207760
<rdar://problem/59458111>
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/page/Frame.cpp (257419 => 257420)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/page/Frame.cpp 2020-02-26 10:54:52 UTC (rev 257419)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/page/Frame.cpp 2020-02-26 10:54:57 UTC (rev 257420)
@@ -960,7 +960,12 @@
m_doc->resumeScheduledTasks(ReasonForSuspension::PageWillBeSuspended);
// Frame::clearTimers() suspended animations and pending relayouts.
- animation().resumeAnimationsForDocument(m_doc.get());
+
+ if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled()) {
+ if (auto* timeline = m_doc->existingTimeline())
+ timeline->resumeAnimations();
+ } else
+ animation().resumeAnimationsForDocument(m_doc.get());
if (m_view)
m_view->layoutContext().scheduleLayout();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
