Title: [257477] trunk/Tools
- Revision
- 257477
- Author
- [email protected]
- Date
- 2020-02-26 09:13:51 -0800 (Wed, 26 Feb 2020)
Log Message
Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
The test was added for macOS and times out on iOS.
* TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (257476 => 257477)
--- trunk/Tools/ChangeLog 2020-02-26 17:13:26 UTC (rev 257476)
+++ trunk/Tools/ChangeLog 2020-02-26 17:13:51 UTC (rev 257477)
@@ -1,3 +1,12 @@
+2020-02-26 Chris Dumez <[email protected]>
+
+ Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
+
+ The test was added for macOS and times out on iOS.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
+ (TEST):
+
2020-02-26 Youenn Fablet <[email protected]>
Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm (257476 => 257477)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm 2020-02-26 17:13:26 UTC (rev 257476)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm 2020-02-26 17:13:51 UTC (rev 257477)
@@ -116,6 +116,7 @@
EXPECT_WK_STREQ("https://webkit.org/\nhttps://apple.com/", [webView stringByEvaluatingJavaScript:@"urlData.textContent"]);
}
+#if PLATFORM(MAC)
TEST(DragAndDropTests, DragAndDropOnEmptyView)
{
auto simulator = adoptNS([[DragAndDropSimulator alloc] initWithWebViewFrame:CGRectMake(0, 0, 320, 500)]);
@@ -124,15 +125,9 @@
NSURL *url = "" mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
-#if PLATFORM(MAC)
NSPasteboard *pasteboard = [NSPasteboard pasteboardWithUniqueName];
[pasteboard writeObjects:@[ url ]];
[simulator setExternalDragPasteboard:pasteboard];
-#else
- auto urlItem = adoptNS([[NSItemProvider alloc] initWithObject:url]);
- urlItem.get().preferredPresentationStyle = UIPreferredPresentationStyleInline;
- [simulator setExternalItemProviders:@[ urlItem.get() ]];
-#endif
[simulator runFrom:CGPointMake(0, 0) to:CGPointMake(100, 100)];
@@ -144,6 +139,7 @@
EXPECT_WK_STREQ("Simple HTML file.", [webView stringByEvaluatingJavaScript:@"document.body.innerText"]);
}
+#endif // PLATFORM(MAC)
TEST(DragAndDropTests, PreventingMouseDownShouldPreventDragStart)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes